You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2017/11/08 20:24:29 UTC
[kudu-CR] clang tidy gerrit: don't require 'requests' module in local mode
Hello Mike Percy,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/8501
to review the following change.
Change subject: clang_tidy_gerrit: don't require 'requests' module in local mode
......................................................................
clang_tidy_gerrit: don't require 'requests' module in local mode
My local python installation appears to not have the 'requests' module
which is required by clang_tidy_gerrit to post comments. This should not
prevent me from running the tidy target in local mode.
Change-Id: I511a5b2e58b7d815f90958bc2cf0ec261dfcc1a4
---
M build-support/clang_tidy_gerrit.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/8501/1
--
To view, visit http://gerrit.cloudera.org:8080/8501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I511a5b2e58b7d815f90958bc2cf0ec261dfcc1a4
Gerrit-Change-Number: 8501
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] clang tidy gerrit: don't require 'requests' module in local mode
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8501 )
Change subject: clang_tidy_gerrit: don't require 'requests' module in local mode
......................................................................
clang_tidy_gerrit: don't require 'requests' module in local mode
My local python installation appears to not have the 'requests' module
which is required by clang_tidy_gerrit to post comments. This should not
prevent me from running the tidy target in local mode.
Change-Id: I511a5b2e58b7d815f90958bc2cf0ec261dfcc1a4
Reviewed-on: http://gerrit.cloudera.org:8080/8501
Tested-by: Todd Lipcon <to...@apache.org>
Reviewed-by: Mike Percy <mp...@apache.org>
---
M build-support/clang_tidy_gerrit.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Todd Lipcon: Verified
Mike Percy: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/8501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I511a5b2e58b7d815f90958bc2cf0ec261dfcc1a4
Gerrit-Change-Number: 8501
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] clang tidy gerrit: don't require 'requests' module in local mode
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has removed a vote on this change.
Change subject: clang_tidy_gerrit: don't require 'requests' module in local mode
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/8501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I511a5b2e58b7d815f90958bc2cf0ec261dfcc1a4
Gerrit-Change-Number: 8501
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] clang tidy gerrit: don't require 'requests' module in local mode
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8501 )
Change subject: clang_tidy_gerrit: don't require 'requests' module in local mode
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I511a5b2e58b7d815f90958bc2cf0ec261dfcc1a4
Gerrit-Change-Number: 8501
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 09 Nov 2017 08:37:42 +0000
Gerrit-HasComments: No
[kudu-CR] clang tidy gerrit: don't require 'requests' module in local mode
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8501 )
Change subject: clang_tidy_gerrit: don't require 'requests' module in local mode
......................................................................
Patch Set 1: Verified+1
unrelated flake (put up a separate patch to bump timeout)
--
To view, visit http://gerrit.cloudera.org:8080/8501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I511a5b2e58b7d815f90958bc2cf0ec261dfcc1a4
Gerrit-Change-Number: 8501
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 08 Nov 2017 23:17:09 +0000
Gerrit-HasComments: No