You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/07/15 04:42:00 UTC
[GitHub] [spark] cloud-fan commented on issue #25035: [SPARK-28235][SQL] Sum
of decimals should return a decimal with MAX_PRECISION
cloud-fan commented on issue #25035: [SPARK-28235][SQL] Sum of decimals should return a decimal with MAX_PRECISION
URL: https://github.com/apache/spark/pull/25035#issuecomment-511272440
I do feel it's just a heuristic. Even if you set the precision to 38 it can still overflow. I don't think this is a better solution compared to `p + 10`, as it's already hard to hit overflow according to https://github.com/apache/spark/pull/25035#discussion_r300271855
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org