You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by DrTall <gi...@git.apache.org> on 2015/06/16 18:38:15 UTC

[GitHub] thrift pull request: Allow construction of TTransportFactory with ...

GitHub user DrTall opened a pull request:

    https://github.com/apache/thrift/pull/521

    Allow construction of TTransportFactory with a specified maxLength.

    Hello,
    
    Maybe I'm going crazy but I don't see any way to construct a TTransportFactory with maxLength set to something other than DEFAULT_MAX_LENGTH. I'd like to do this so I can pass this tFramedTransportFactory into NewTSimpleServer4.
    
    Thanks,
    Sean

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DrTall/thrift patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/521.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #521
    
----
commit 9a2badf31a16a0a0d9710a1c44bf406ba42e60cb
Author: Sean <dr...@users.noreply.github.com>
Date:   2015-06-16T16:38:02Z

    Allow construction of TTransportFactory with a specified maxLength.
    
    Hello,
    
    Maybe I'm going crazy but I don't see any way to construct a TTransportFactory with maxLength set to something other than DEFAULT_MAX_LENGTH. I'd like to do this so I can pass this tFramedTransportFactory into NewTSimpleServer4.
    
    Thanks,
    Sean

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Allow construction of TTransportFactory with ...

Posted by DrTall <gi...@git.apache.org>.
Github user DrTall commented on the pull request:

    https://github.com/apache/thrift/pull/521#issuecomment-114219243
  
    Hello,
    
    I've created https://issues.apache.org/jira/browse/THRIFT-3198 corresponding to this pull request.
    
    Thanks,
    Sean


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Allow construction of TTransportFactory with ...

Posted by Jens-G <gi...@git.apache.org>.
Github user Jens-G commented on the pull request:

    https://github.com/apache/thrift/pull/521#issuecomment-113615585
  
    Ping


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Allow construction of TTransportFactory with ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/thrift/pull/521


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Allow construction of TTransportFactory with ...

Posted by Jens-G <gi...@git.apache.org>.
Github user Jens-G commented on the pull request:

    https://github.com/apache/thrift/pull/521#issuecomment-112940345
  
    Thanks! 
    
    Could you just {file a JIRA ticket|http://thrift.apache.org/docs/HowToContribute] and mention its number in a comment here? That would be awesome!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---