[GitHub] TryHarder01 commented on issue #3786: Fix issue: Oracle backend: pandas Exception : KeyError #953 with models.py change

[GitBox <gi...@apache.org>]

TryHarder01 commented on issue #3786: Fix issue: Oracle backend: pandas Exception : KeyError #953 with models.py change 
URL: https://github.com/apache/incubator-superset/pull/3786#issuecomment-342318982
 
 
   @xrmx not sure. I'm using the `query_object` that gets passed into the `query()` method in `models.py` in order to exclude the agg/metrics columns calculated by superset (things like, "min__X").
   
   If I go up to `core.Database.get_df` I don't have access to that anymore (as far as I can tell).
   
   I'll have a SQL output that has columns "orders, data, min_PRICE" and I want to make sure I only upper() the first two, since Superset is expect "min_PRICE" just like that. The `query_obj['metrics']` gives me access to the columns that should be left unchanged. 
   
   I'm up for improvements, but when trying to make your change the code fails without accessing that variable. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services