You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/05/09 19:08:42 UTC

[GitHub] [pulsar] michaeljmarshall commented on pull request #15238: use netty PlatformDependent.estimateMaxDirectMemory

michaeljmarshall commented on PR #15238:
URL: https://github.com/apache/pulsar/pull/15238#issuecomment-1121471566

   > @michaeljmarshall My bad The main reason I want to replace is that `maxDirectMemory()` can be changed by system property `io.netty.maxDirectMemory`, which will may lead to wrong result. To avoid performance regression, I think we can put it in a common class, and others use the result. What do you think?
   
   Is it possible that it is a feature, not a bug, that we expose `io.netty.maxDirectMemory` to end users? If a user configures `io.netty.maxDirectMemory` poorly, I wouldn't consider that a performance regression.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org