You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Gregory Chanan <gc...@cloudera.com> on 2016/02/08 09:18:34 UTC
Review Request 43325: SENTRY-1055: Sentry service solr constants
refer to clusters rather than services
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43325/
-----------------------------------------------------------
Review request for sentry, Colin Ma, Lenni Kuff, and Sravya Tirukkovalur.
Repository: sentry
Description
-------
I think it makes sense to change this now for consistency sake with the generic client and the shell, which refer to services rather than clusters.
Diffs
-----
sentry-binding/sentry-binding-solr/src/main/java/org/apache/sentry/binding/solr/authz/SolrAuthzBinding.java 88148c417043b4c88d9b4c42940f42dbec4dae4c
sentry-core/sentry-core-model-search/src/main/java/org/apache/sentry/core/model/search/SearchConstants.java 36f5b21c16c80bfa00899721b25321546f2071c6
sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/db/integration/AbstractSolrSentryTestWithDbProvider.java 29a5981cbdb45a9122bb0a800e2c652d26a65834
sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/db/integration/TestSolrAdminOperations.java 69b90660496702eb2f164534bfe7e23e3bb4c28d
sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/db/integration/TestSolrQueryOperations.java 663350d00bc1e842b5ff634dde024439eb0849b0
Diff: https://reviews.apache.org/r/43325/diff/
Testing
-------
Thanks,
Gregory Chanan
Re: Review Request 43325: SENTRY-1055: Sentry service solr constants
refer to clusters rather than services
Posted by Hao Hao <ha...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43325/#review119376
-----------------------------------------------------------
Ship it!
Ship It!
- Hao Hao
On Feb. 8, 2016, 8:18 a.m., Gregory Chanan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43325/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2016, 8:18 a.m.)
>
>
> Review request for sentry, Colin Ma, Lenni Kuff, and Sravya Tirukkovalur.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> I think it makes sense to change this now for consistency sake with the generic client and the shell, which refer to services rather than clusters.
>
>
> Diffs
> -----
>
> sentry-binding/sentry-binding-solr/src/main/java/org/apache/sentry/binding/solr/authz/SolrAuthzBinding.java 88148c417043b4c88d9b4c42940f42dbec4dae4c
> sentry-core/sentry-core-model-search/src/main/java/org/apache/sentry/core/model/search/SearchConstants.java 36f5b21c16c80bfa00899721b25321546f2071c6
> sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/db/integration/AbstractSolrSentryTestWithDbProvider.java 29a5981cbdb45a9122bb0a800e2c652d26a65834
> sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/db/integration/TestSolrAdminOperations.java 69b90660496702eb2f164534bfe7e23e3bb4c28d
> sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/db/integration/TestSolrQueryOperations.java 663350d00bc1e842b5ff634dde024439eb0849b0
>
> Diff: https://reviews.apache.org/r/43325/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gregory Chanan
>
>