[GitHub] [iceberg] marton-bod commented on issue #2249: Unset no longer present table props while propagating props to HMS

[GitBox <gi...@apache.org>]

marton-bod commented on issue #2249:
URL: https://github.com/apache/iceberg/issues/2249#issuecomment-781341675


   Hi Anton, 
   Good point. I agree that we should try to keep the Iceberg and HMS table props in sync (perhaps with some additional props present only in HMS, as needed by Hive). There are 2 directions here:
   - Iceberg -> HMS: New and updated Iceberg properties are already pushed to HMS. As for deleted props, I can work on unsetting any HMS properties that are no longer present in the Iceberg table props. At first glance, this would be based on which keys are present in `base.properties()`, but are no longer present in `metadata.properties()` in `doCommit`.
   - HMS -> Iceberg: Our plan is to extend the hive `MetaHook` interface to add a `postAlterTable` method which is currently missing that'd enable users to run an `ALTER TABLE tbl SET TBLPROPERTIES('foo'='bar')` DDL from hive and get the prop change pushed down the to the Iceberg table props as well.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org