You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Christian Grobmeier <gr...@gmail.com> on 2009/05/14 07:54:47 UTC

[VOTE] Release commons-compress-1.0 based on RC2 (Rev: 774630)

Hi all,

RC2 is based on SVN revision: 774630

It includes minor changes on the site, corrects svn properties and
makes a testcase run on win xp.

Please vote:

Tag:
https://svn.apache.org/repos/asf/commons/proper/compress/tags/commons-compress-1.0/

Site:
http://people.apache.org/builds/commons/compress/1.0/RC2/site/index.html

Binaries:
http://people.apache.org/builds/commons/compress/1.0/RC2/staged/org/apache/commons/commons-compress/1.0/


[ ] +1 release it
[ ] +0 go ahead I don't care
[ ] -1 no, do not release it because

Best regards,
Christian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release commons-compress-1.0 based on RC2 (Rev: 774630)

Posted by Stefan Bodewig <bo...@apache.org>.
On 2009-05-14, Christian Grobmeier <gr...@gmail.com> wrote:

> [X] +1 release it
> [ ] +0 go ahead I don't care
> [ ] -1 no, do not release it because


+1, go ahead.

some of the tests fail occasionally on my Windows box but this is an
issue of the tests, not the code itself (some timing problems).

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release commons-compress-1.0 based on RC2 (Rev: 774630)

Posted by Stefan Bodewig <bo...@apache.org>.
On 2009-05-18, sebb <se...@gmail.com> wrote:

> On 15/05/2009, Oliver Heger <ol...@oliver-heger.de> wrote:

>> I think md5 checksums are required for all artifacts. They are currently
>> missing.

> Agreed.
> Could perhaps add sha1 as well, but not essential

md5s and sha1s are now there and match.

sha512 might be a good addition going forward, but certainly not
required for this release.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release commons-compress-1.0 based on RC2 (Rev: 774630)

Posted by Christian Grobmeier <gr...@gmail.com>.
>>  I think md5 checksums are required for all artifacts. They are currently
>> missing.
>
> Could perhaps add sha1 as well, but not essential
> No need to re-roll the release; just create the hashes.

Hashes are available now
Thanks
Christian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release commons-compress-1.0 based on RC2 (Rev: 774630)

Posted by sebb <se...@gmail.com>.
On 15/05/2009, Oliver Heger <ol...@oliver-heger.de> wrote:
> The artifacts look good, the build works fine with JDK 1.4 and 1.6.

Builds and tests OK for me with 1.4.

>  I think md5 checksums are required for all artifacts. They are currently
> missing.

Agreed.
Could perhaps add sha1 as well, but not essential

No need to re-roll the release; just create the hashes.

>  The PMD report contains a bunch of errors.

Many of which are incorrect, e.g. "Do not start a literal by 0 unless
it's an octal value" is reported lots of times; the values are in fact
octal.

Likewise "Avoid empty catch blocks" - these are deliberate.

I think the problem here is the PMD rules need tweaking.

> I also ran findbugs and got 32
> errors. None of them seem to be critical, so this is not a blocker.

I only get 21 warnings, and most of these are in the test cases.

>  So +1 for the release.

+1 for release, provided that the MD5 hashes are generated.

>  Oliver
>
>  Christian Grobmeier schrieb:
>
>
> > Hi all,
> >
> > RC2 is based on SVN revision: 774630
> >
> > It includes minor changes on the site, corrects svn properties and
> > makes a testcase run on win xp.
> >
> > Please vote:
> >
> > Tag:
> >
> https://svn.apache.org/repos/asf/commons/proper/compress/tags/commons-compress-1.0/
> >
> > Site:
> >
> http://people.apache.org/builds/commons/compress/1.0/RC2/site/index.html
> >
> > Binaries:
> >
> http://people.apache.org/builds/commons/compress/1.0/RC2/staged/org/apache/commons/commons-compress/1.0/
> >
> >
> > [ ] +1 release it
> > [ ] +0 go ahead I don't care
> > [ ] -1 no, do not release it because
> >
> > Best regards,
> > Christian
> >
> >
> ---------------------------------------------------------------------
> > To unsubscribe, e-mail:
> dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
>
>
> ---------------------------------------------------------------------
>  To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>  For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release commons-compress-1.0 based on RC2 (Rev: 774630)

Posted by Oliver Heger <ol...@oliver-heger.de>.
The artifacts look good, the build works fine with JDK 1.4 and 1.6.

I think md5 checksums are required for all artifacts. They are currently 
missing.

The PMD report contains a bunch of errors. I also ran findbugs and got 
32 errors. None of them seem to be critical, so this is not a blocker.

So +1 for the release.

Oliver

Christian Grobmeier schrieb:
> Hi all,
> 
> RC2 is based on SVN revision: 774630
> 
> It includes minor changes on the site, corrects svn properties and
> makes a testcase run on win xp.
> 
> Please vote:
> 
> Tag:
> https://svn.apache.org/repos/asf/commons/proper/compress/tags/commons-compress-1.0/
> 
> Site:
> http://people.apache.org/builds/commons/compress/1.0/RC2/site/index.html
> 
> Binaries:
> http://people.apache.org/builds/commons/compress/1.0/RC2/staged/org/apache/commons/commons-compress/1.0/
> 
> 
> [ ] +1 release it
> [ ] +0 go ahead I don't care
> [ ] -1 no, do not release it because
> 
> Best regards,
> Christian
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release commons-compress-1.0 based on RC2 (Rev: 774630)

Posted by Torsten Curdt <tc...@apache.org>.
also +1 from me!

On Mon, May 18, 2009 at 19:39, Jörg Schaible <jo...@gmx.de> wrote:
> +1
>
> Could build from the src package running all tests with my complete compiler
> zoo.
>
> - Jörg
>
> Christian Grobmeier wrote:
>
>> Hi all,
>>
>> RC2 is based on SVN revision: 774630
>>
>> It includes minor changes on the site, corrects svn properties and
>> makes a testcase run on win xp.
>>
>> Please vote:
>>
>> Tag:
>>
> https://svn.apache.org/repos/asf/commons/proper/compress/tags/commons-compress-1.0/
>>
>> Site:
>> http://people.apache.org/builds/commons/compress/1.0/RC2/site/index.html
>>
>> Binaries:
>>
> http://people.apache.org/builds/commons/compress/1.0/RC2/staged/org/apache/commons/commons-compress/1.0/
>>
>>
>> [ ] +1 release it
>> [ ] +0 go ahead I don't care
>> [ ] -1 no, do not release it because
>>
>> Best regards,
>> Christian
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release commons-compress-1.0 based on RC2 (Rev: 774630)

Posted by Jörg Schaible <jo...@gmx.de>.
+1

Could build from the src package running all tests with my complete compiler
zoo.

- Jörg

Christian Grobmeier wrote:

> Hi all,
> 
> RC2 is based on SVN revision: 774630
> 
> It includes minor changes on the site, corrects svn properties and
> makes a testcase run on win xp.
> 
> Please vote:
> 
> Tag:
>
https://svn.apache.org/repos/asf/commons/proper/compress/tags/commons-compress-1.0/
> 
> Site:
> http://people.apache.org/builds/commons/compress/1.0/RC2/site/index.html
> 
> Binaries:
>
http://people.apache.org/builds/commons/compress/1.0/RC2/staged/org/apache/commons/commons-compress/1.0/
> 
> 
> [ ] +1 release it
> [ ] +0 go ahead I don't care
> [ ] -1 no, do not release it because
> 
> Best regards,
> Christian



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


[RESULT][VOTE] Release commons-compress-1.0 based on RC2 (Rev: 774630)

Posted by Christian Grobmeier <gr...@gmail.com>.
Hi all,

this vote passes with atleast 6 +1s votes from:

- Oliver Heger
- Sebastian Bazley
- Stefan Bodewig
- Jörg Schaible
- Torsten Curdt
- Jukka Zitting (non binding)

Thanks for your time! I will do the last steps quite soon.

Cheers,
Christian

---------- Forwarded message ----------
From: Christian Grobmeier <gr...@gmail.com>
Date: Thu, May 14, 2009 at 7:54 AM
Subject: [VOTE] Release commons-compress-1.0 based on RC2 (Rev: 774630)
To: Commons Developers List <de...@commons.apache.org>


Hi all,

RC2 is based on SVN revision: 774630

It includes minor changes on the site, corrects svn properties and
makes a testcase run on win xp.

Please vote:

Tag:
https://svn.apache.org/repos/asf/commons/proper/compress/tags/commons-compress-1.0/

Site:
http://people.apache.org/builds/commons/compress/1.0/RC2/site/index.html

Binaries:
http://people.apache.org/builds/commons/compress/1.0/RC2/staged/org/apache/commons/commons-compress/1.0/


[ ] +1 release it
[ ] +0 go ahead I don't care
[ ] -1 no, do not release it because

Best regards,
Christian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release commons-compress-1.0 based on RC2 (Rev: 774630)

Posted by sebb <se...@gmail.com>.
On 21/05/2009, Jukka Zitting <ju...@gmail.com> wrote:
> Hi,
>
>  Sorry for being late...
>
>
>  On Thu, May 14, 2009 at 7:54 AM, Christian Grobmeier
>  <gr...@gmail.com> wrote:
>  > RC2 is based on SVN revision: 774630
>
>
> [x] +1 release it (non-binding)
>
>  Reviewed the commons-compress-1.0-src.tar.gz package with SHA1 sum
>  e2cda720dd116a5172f56528a6c212fe56f372ef. Matches the svn tag (except
>  for the PROPOSAL.txt and doap_compress.rdf files, why?), builds and
>  passes tests on Vista with Java 6, works well with Apache Tika.

The PROPOSAL is not really relevant to end-users.
The DOAP file is only relevant for the projects web-site.

[I think the DOAP files should not be in trunk at all]

>  The only concern I have are the extra entries in NOTICE.txt. As
>  discussed earlier, I'd rather see them in a README file. No need to
>  cancel 1.0 for this, but I filed COMPRESS-72 so we remember to fix
>  this for future releases.
>
>  BR,
>
>
>  Jukka Zitting
>
>
>  ---------------------------------------------------------------------
>  To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>  For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release commons-compress-1.0 based on RC2 (Rev: 774630)

Posted by Jukka Zitting <ju...@gmail.com>.
Hi,

Sorry for being late...

On Thu, May 14, 2009 at 7:54 AM, Christian Grobmeier
<gr...@gmail.com> wrote:
> RC2 is based on SVN revision: 774630

[x] +1 release it (non-binding)

Reviewed the commons-compress-1.0-src.tar.gz package with SHA1 sum
e2cda720dd116a5172f56528a6c212fe56f372ef. Matches the svn tag (except
for the PROPOSAL.txt and doap_compress.rdf files, why?), builds and
passes tests on Vista with Java 6, works well with Apache Tika.

The only concern I have are the extra entries in NOTICE.txt. As
discussed earlier, I'd rather see them in a README file. No need to
cancel 1.0 for this, but I filed COMPRESS-72 so we remember to fix
this for future releases.

BR,

Jukka Zitting

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org