You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by "laimis (via GitHub)" <gi...@apache.org> on 2023/04/12 20:30:06 UTC
[GitHub] [lucenenet] laimis opened a new pull request, #824: add ignore attributes
laimis opened a new pull request, #824:
URL: https://github.com/apache/lucenenet/pull/824
Continuation of fixes with virtual calls being made from constructors. The issue originally reported by SonarCloud scans: https://sonarcloud.io/project/issues?resolved=false&rules=csharpsquid%3AS1699&id=apache_lucenenet and referenced in this issue: https://github.com/apache/lucenenet/issues/670
JaspellTernarySearchTrie gets removed in the later versions of Lucene: https://github.com/apache/lucene/commit/4213f9d3cd1742082ebac74fb6510dc8c46bfd95. It is not worth it for us to find a way to extend this class without virtual method calls being a potential issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] laimis commented on pull request #824: add ignore attributes
Posted by "laimis (via GitHub)" <gi...@apache.org>.
laimis commented on PR #824:
URL: https://github.com/apache/lucenenet/pull/824#issuecomment-1507264237
Added the comments suggesting the culture info override.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] laimis merged pull request #824: add ignore attributes
Posted by "laimis (via GitHub)" <gi...@apache.org>.
laimis merged PR #824:
URL: https://github.com/apache/lucenenet/pull/824
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org