You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/11 04:17:28 UTC
[GitHub] [airflow-site] rossturk opened a new pull request, #634: Undockerize local & CI site builds
rossturk opened a new pull request, #634:
URL: https://github.com/apache/airflow-site/pull/634
While I was working on #629, @potiuk recommended moving away from Docker for the functions of `site.sh`.
This updates the shell script to remove all of the Docker command execution, and makes changes throughout to remove hardcoded paths. It updates the GitHub workflow to install Hugo and Node, and it adds a few steps to the contributor docs to show users how to do the same.
As a side-effect, this makes `site.sh` and its related tools/processes work on ARM-based macOS machines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-site] potiuk commented on pull request #634: Undockerize local & CI site builds
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #634:
URL: https://github.com/apache/airflow-site/pull/634#issuecomment-1184317090
yep. You need yarn to be installed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-site] potiuk commented on pull request #634: Undockerize local & CI site builds
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #634:
URL: https://github.com/apache/airflow-site/pull/634#issuecomment-1181984608
Merge running https://github.com/apache/airflow-site/actions/runs/2657942667 , let's see.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-site] potiuk commented on pull request #634: Undockerize local & CI site builds
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #634:
URL: https://github.com/apache/airflow-site/pull/634#issuecomment-1181983982
> > @potiuk ok! cleanup is done now, thanks for merging that other PR!
> > Fingers crossed. The GitHub workflow does different stuff on merge to main, hope there aren't surprises.
>
> Will there be any surprises, we will fix them :)
BTW. The way I test merges to main (airlfow has VASTLY different workflow when merging) is `git push -f my_fork my_branch:main` -> this will push your branch as main (i..e. same as merge) and if you configure the same SECRETS that we have in "apache" in your fork + make sure that the "bucket" name is configurable from secret (I think it is) you can test merge workflow in your own fork with relative ease
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-site] eladkal commented on pull request #634: Undockerize local & CI site builds
Posted by GitBox <gi...@apache.org>.
eladkal commented on PR #634:
URL: https://github.com/apache/airflow-site/pull/634#issuecomment-1180383491
Noting that `site.sh` is to be replaced with Python version
https://github.com/apache/airflow-site/pull/623
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-site] potiuk commented on pull request #634: Undockerize local & CI site builds
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #634:
URL: https://github.com/apache/airflow-site/pull/634#issuecomment-1181980291
> @potiuk ok! cleanup is done now, thanks for merging that other PR!
>
> Fingers crossed. The GitHub workflow does different stuff on merge to main, hope there aren't surprises.
Will there be any surprises, we will fix them :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-site] Bowrna commented on pull request #634: Undockerize local & CI site builds
Posted by GitBox <gi...@apache.org>.
Bowrna commented on PR #634:
URL: https://github.com/apache/airflow-site/pull/634#issuecomment-1184284110
@rossturk I get an error saying `yarn` command not found in my local machine( m1 mac os). Am I missing executing any specific step in documentation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-site] potiuk commented on pull request #634: Undockerize local & CI site builds
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #634:
URL: https://github.com/apache/airflow-site/pull/634#issuecomment-1181990633
All good. Build is Green, the website did not blow up :) :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-site] potiuk merged pull request #634: Undockerize local & CI site builds
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #634:
URL: https://github.com/apache/airflow-site/pull/634
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-site] potiuk commented on pull request #634: Undockerize local & CI site builds
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #634:
URL: https://github.com/apache/airflow-site/pull/634#issuecomment-1181662279
I think conflict needs resolving :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-site] rossturk commented on pull request #634: Undockerize local & CI site builds
Posted by GitBox <gi...@apache.org>.
rossturk commented on PR #634:
URL: https://github.com/apache/airflow-site/pull/634#issuecomment-1181894808
@potiuk ok! cleanup is done now, thanks for merging that other PR!
Fingers crossed. The GitHub workflow does different stuff on merge to main, hope there aren't surprises.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org