[GitHub] [hudi] scxwhite commented on a change in pull request #4932: [HUDI-3069] compact improve

[GitBox <gi...@apache.org>]

scxwhite commented on a change in pull request #4932:
URL: https://github.com/apache/hudi/pull/4932#discussion_r817492078



##########
File path: hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieMergedLogRecordScanner.java
##########
@@ -143,9 +143,11 @@ protected void processNextRecord(HoodieRecord<? extends HoodieRecordPayload> hoo
       HoodieRecord<? extends HoodieRecordPayload> oldRecord = records.get(key);
       HoodieRecordPayload oldValue = oldRecord.getData();
       HoodieRecordPayload combinedValue = hoodieRecord.getData().preCombine(oldValue);
-      boolean choosePrev = combinedValue.equals(oldValue);
-      HoodieOperation operation = choosePrev ? oldRecord.getOperation() : hoodieRecord.getOperation();
-      records.put(key, new HoodieAvroRecord<>(new HoodieKey(key, hoodieRecord.getPartitionPath()), combinedValue, operation));
+      // If combinedValue is oldValue, no need rePut oldRecord
+      if (!combinedValue.equals(oldValue)) {
+        HoodieOperation operation = hoodieRecord.getOperation();

Review comment:
       fixed. please review again.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org