You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@karaf.apache.org by "Torsten Mielke (JIRA)" <ji...@apache.org> on 2011/01/27 16:22:46 UTC
[jira] Created: (KARAF-423) KarafJaasPasswordAuthenticator should
log reason for authentication failure.
KarafJaasPasswordAuthenticator should log reason for authentication failure.
----------------------------------------------------------------------------
Key: KARAF-423
URL: https://issues.apache.org/jira/browse/KARAF-423
Project: Karaf
Issue Type: Improvement
Components: runtime
Affects Versions: 2.1.3
Environment: Karaf trunk
Reporter: Torsten Mielke
Priority: Minor
Attachments: Kara-423f.patch
In method KarafJaasPasswordAuthenticator.authenticate() we catch any exceptions at the end and only return false in the event of an exception
{code:java}
} catch (Exception e) {
return false;
}
{code}
without logging anything about the reason for the exception, e.g. in case of a FailedLoginException.
I propose to add some logging in the exception handling. Perhaps at INFO level so that it gets written to the log file by default.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (KARAF-423) KarafJaasPasswordAuthenticator should
log reason for authentication failure.
Posted by "Andreas Pieber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Pieber updated KARAF-423:
---------------------------------
Fix Version/s: 2.2.0
2.1.4
> KarafJaasPasswordAuthenticator should log reason for authentication failure.
> ----------------------------------------------------------------------------
>
> Key: KARAF-423
> URL: https://issues.apache.org/jira/browse/KARAF-423
> Project: Karaf
> Issue Type: Improvement
> Components: runtime
> Affects Versions: 2.1.3
> Environment: Karaf trunk
> Reporter: Torsten Mielke
> Assignee: Andreas Pieber
> Priority: Minor
> Fix For: 2.1.4, 2.2.0
>
> Attachments: Kara-423f.patch
>
>
> In method KarafJaasPasswordAuthenticator.authenticate() we catch any exceptions at the end and only return false in the event of an exception
> } catch (Exception e) {
> return false;
> }
> without logging anything about the reason for the exception, e.g. in case of a FailedLoginException.
> I propose to add some logging in the exception handling. Perhaps at INFO level so that it gets written to the log file by default.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (KARAF-423) KarafJaasPasswordAuthenticator should
log reason for authentication failure.
Posted by "Torsten Mielke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Torsten Mielke updated KARAF-423:
---------------------------------
Attachment: Kara-423f.patch
Proposed patch attached.
I personally would log the message at info level but I noticed other LoginModules also only log at debug.
> KarafJaasPasswordAuthenticator should log reason for authentication failure.
> ----------------------------------------------------------------------------
>
> Key: KARAF-423
> URL: https://issues.apache.org/jira/browse/KARAF-423
> Project: Karaf
> Issue Type: Improvement
> Components: runtime
> Affects Versions: 2.1.3
> Environment: Karaf trunk
> Reporter: Torsten Mielke
> Priority: Minor
> Attachments: Kara-423f.patch
>
>
> In method KarafJaasPasswordAuthenticator.authenticate() we catch any exceptions at the end and only return false in the event of an exception
> {code:java}
> } catch (Exception e) {
> return false;
> }
> {code}
> without logging anything about the reason for the exception, e.g. in case of a FailedLoginException.
> I propose to add some logging in the exception handling. Perhaps at INFO level so that it gets written to the log file by default.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Closed] (KARAF-423) KarafJaasPasswordAuthenticator should
log reason for authentication failure.
Posted by "Jamie goodyear (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jamie goodyear closed KARAF-423.
--------------------------------
> KarafJaasPasswordAuthenticator should log reason for authentication failure.
> ----------------------------------------------------------------------------
>
> Key: KARAF-423
> URL: https://issues.apache.org/jira/browse/KARAF-423
> Project: Karaf
> Issue Type: Improvement
> Components: karaf-core
> Affects Versions: 2.2.0
> Environment: Karaf trunk
> Reporter: Torsten Mielke
> Assignee: Andreas Pieber
> Priority: Minor
> Fix For: 2.2.0
>
> Attachments: Kara-423f.patch
>
>
> In method KarafJaasPasswordAuthenticator.authenticate() we catch any exceptions at the end and only return false in the event of an exception
> } catch (Exception e) {
> return false;
> }
> without logging anything about the reason for the exception, e.g. in case of a FailedLoginException.
> I propose to add some logging in the exception handling. Perhaps at INFO level so that it gets written to the log file by default.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (KARAF-423) KarafJaasPasswordAuthenticator should
log reason for authentication failure.
Posted by "Andreas Pieber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Pieber reassigned KARAF-423:
------------------------------------
Assignee: Andreas Pieber
> KarafJaasPasswordAuthenticator should log reason for authentication failure.
> ----------------------------------------------------------------------------
>
> Key: KARAF-423
> URL: https://issues.apache.org/jira/browse/KARAF-423
> Project: Karaf
> Issue Type: Improvement
> Components: runtime
> Affects Versions: 2.1.3
> Environment: Karaf trunk
> Reporter: Torsten Mielke
> Assignee: Andreas Pieber
> Priority: Minor
> Fix For: 2.1.4, 2.2.0
>
> Attachments: Kara-423f.patch
>
>
> In method KarafJaasPasswordAuthenticator.authenticate() we catch any exceptions at the end and only return false in the event of an exception
> } catch (Exception e) {
> return false;
> }
> without logging anything about the reason for the exception, e.g. in case of a FailedLoginException.
> I propose to add some logging in the exception handling. Perhaps at INFO level so that it gets written to the log file by default.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (KARAF-423) KarafJaasPasswordAuthenticator should
log reason for authentication failure.
Posted by "Andreas Pieber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Pieber resolved KARAF-423.
----------------------------------
Resolution: Fixed
Fix Version/s: (was: 2.1.4)
Pushed in revision 1064836
I've modified your patch in the following points:
1) we typical use commons logging instead of slf4j directly
2) + e would add the class ID ; I've changed it to e.getMessage(), e); to include the entire exception in the log and not only the message
> KarafJaasPasswordAuthenticator should log reason for authentication failure.
> ----------------------------------------------------------------------------
>
> Key: KARAF-423
> URL: https://issues.apache.org/jira/browse/KARAF-423
> Project: Karaf
> Issue Type: Improvement
> Components: runtime
> Affects Versions: 2.2.0
> Environment: Karaf trunk
> Reporter: Torsten Mielke
> Assignee: Andreas Pieber
> Priority: Minor
> Fix For: 2.2.0
>
> Attachments: Kara-423f.patch
>
>
> In method KarafJaasPasswordAuthenticator.authenticate() we catch any exceptions at the end and only return false in the event of an exception
> } catch (Exception e) {
> return false;
> }
> without logging anything about the reason for the exception, e.g. in case of a FailedLoginException.
> I propose to add some logging in the exception handling. Perhaps at INFO level so that it gets written to the log file by default.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (KARAF-423) KarafJaasPasswordAuthenticator should
log reason for authentication failure.
Posted by "Andreas Pieber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Pieber updated KARAF-423:
---------------------------------
Affects Version/s: (was: 2.1.3)
2.2.0
This only affects the current trunk; this class does not exist in 2.1.x branch
> KarafJaasPasswordAuthenticator should log reason for authentication failure.
> ----------------------------------------------------------------------------
>
> Key: KARAF-423
> URL: https://issues.apache.org/jira/browse/KARAF-423
> Project: Karaf
> Issue Type: Improvement
> Components: runtime
> Affects Versions: 2.2.0
> Environment: Karaf trunk
> Reporter: Torsten Mielke
> Assignee: Andreas Pieber
> Priority: Minor
> Fix For: 2.1.4, 2.2.0
>
> Attachments: Kara-423f.patch
>
>
> In method KarafJaasPasswordAuthenticator.authenticate() we catch any exceptions at the end and only return false in the event of an exception
> } catch (Exception e) {
> return false;
> }
> without logging anything about the reason for the exception, e.g. in case of a FailedLoginException.
> I propose to add some logging in the exception handling. Perhaps at INFO level so that it gets written to the log file by default.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (KARAF-423) KarafJaasPasswordAuthenticator should
log reason for authentication failure.
Posted by "Torsten Mielke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Torsten Mielke updated KARAF-423:
---------------------------------
Description:
In method KarafJaasPasswordAuthenticator.authenticate() we catch any exceptions at the end and only return false in the event of an exception
} catch (Exception e) {
return false;
}
without logging anything about the reason for the exception, e.g. in case of a FailedLoginException.
I propose to add some logging in the exception handling. Perhaps at INFO level so that it gets written to the log file by default.
was:
In method KarafJaasPasswordAuthenticator.authenticate() we catch any exceptions at the end and only return false in the event of an exception
{code:java}
} catch (Exception e) {
return false;
}
{code}
without logging anything about the reason for the exception, e.g. in case of a FailedLoginException.
I propose to add some logging in the exception handling. Perhaps at INFO level so that it gets written to the log file by default.
> KarafJaasPasswordAuthenticator should log reason for authentication failure.
> ----------------------------------------------------------------------------
>
> Key: KARAF-423
> URL: https://issues.apache.org/jira/browse/KARAF-423
> Project: Karaf
> Issue Type: Improvement
> Components: runtime
> Affects Versions: 2.1.3
> Environment: Karaf trunk
> Reporter: Torsten Mielke
> Priority: Minor
> Attachments: Kara-423f.patch
>
>
> In method KarafJaasPasswordAuthenticator.authenticate() we catch any exceptions at the end and only return false in the event of an exception
> } catch (Exception e) {
> return false;
> }
> without logging anything about the reason for the exception, e.g. in case of a FailedLoginException.
> I propose to add some logging in the exception handling. Perhaps at INFO level so that it gets written to the log file by default.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.