[GitHub] [dubbo] huangwenkan9 commented on a change in pull request #9052: remove StdErrLog from JettyHttpServer

[GitBox <gi...@apache.org>]

huangwenkan9 commented on a change in pull request #9052:
URL: https://github.com/apache/dubbo/pull/9052#discussion_r735068445



##########
File path: dubbo-remoting/dubbo-remoting-http/src/main/java/org/apache/dubbo/remoting/http/jetty/JettyHttpServer.java
##########
@@ -49,10 +49,6 @@
     public JettyHttpServer(URL url, final HttpHandler handler) {
         super(url, handler);
         this.url = url;
-        // TODO we should leave this setting to slf4j
-        // we must disable the debug logging for production use
-        Log.setLog(new StdErrLog());

Review comment:
       but dubbo's logger and jetty's logger don't match. should i create an adapter for them?  give me some ideas!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org