[GitHub] [ozone] umamaheswararao commented on pull request #3120: HDDS-6358. EC: Refactor ECKeyOutputStream#write()

[GitBox <gi...@apache.org>]

umamaheswararao commented on pull request #3120:
URL: https://github.com/apache/ozone/pull/3120#issuecomment-1047903513


   Thanks for filing this @kaijchen
   Initially journey was started with this single [loop | https://github.com/apache/ozone/blob/f9a0782ae4efebabb55127df3954745a3c4a0889/hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/io/ECKeyOutputStream.java] 
   However for easy trace tracking at which position write impacted, I have decided to split into 3 sections as you got that in summary comments. 
   I think now, we have evolved enough and bit stable compared to starting point where we need lot of debug help info to track down issues. ( When it has 3 sections I found helpful as the trace indicates which position of data sizes it's causing issues. We may need to add more debug info as well to improve debug-ability.)
   
   Overall patch looks good to me. I will pass one more round as this is in key path and provide my feedback if any.
   
   Thanks a lot for working on this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org