You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "turboFei (via GitHub)" <gi...@apache.org> on 2026/05/15 17:37:00 UTC

[PR] [CELEBORN-2328] auto-apply correctness label from PR template checkbox [celeborn]

turboFei opened a new pull request, #3688:
URL: https://github.com/apache/celeborn/pull/3688

   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     - Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
     - Be sure to keep the PR description updated to reflect all changes.
     - Please write your PR title to summarize what this PR proposes.
     - If possible, provide a concise example to reproduce the issue for a faster review.
   -->
   
   ### What changes were proposed in this pull request?
   
   Replace the free-text `Yes/No` comment under "Does this PR resolve a correctness bug?" with a single checkbox in the PR template. Add a GitHub Actions workflow (`correctness-label.yml`) that automatically adds or removes the `correctness` label based on whether the box is checked, triggered on every PR open/edit.
   
   ### Why are the changes needed?
   
   Previously the note said "committer will add `correctness` label" — a manual step that was easy to miss. This automates it: checking the box applies the label immediately, and unchecking it removes the label, with no committer action required.
   
   ### Does this PR resolve a correctness bug?
   
   <!-- Check if yes. The `correctness` label will be added/removed automatically. -->
   - [x] Yes
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   CI workflow logic verified by code review. End-to-end behavior can be confirmed by opening a test PR against the repo and toggling the checkbox.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-2328] Auto-apply correctness label from PR template checkbox [celeborn]

Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas closed pull request #3688: [CELEBORN-2328] Auto-apply correctness label from PR template checkbox
URL: https://github.com/apache/celeborn/pull/3688


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-2328] Auto-apply correctness label from PR template checkbox [celeborn]

Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #3688:
URL: https://github.com/apache/celeborn/pull/3688#discussion_r3256087211


##########
.github/PULL_REQUEST_TEMPLATE.md:
##########
@@ -16,7 +16,8 @@ Thanks for sending a pull request!  Here are some tips for you:
 
 ### Does this PR resolve a correctness bug?
 
-<!-- Yes/No. (Note: If yes, committer will add `correctness` label to current pull request). -->
+<!-- Check if yes. The `correctness` label will be added/removed automatically. -->
+- [ ] Yes
 
 ### Does this PR introduce _any_ user-facing change?

Review Comment:
   Could this also use `- [ ] Yes.` for `Does this PR introduce _any_ user-facing change`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-2328] Auto-apply correctness label from PR template checkbox [celeborn]

Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on PR #3688:
URL: https://github.com/apache/celeborn/pull/3688#issuecomment-4484223500

   Thanks. Merged to main(v0.7.0).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-2328] Auto-apply correctness label from PR template checkbox [celeborn]

Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on code in PR #3688:
URL: https://github.com/apache/celeborn/pull/3688#discussion_r3263264959


##########
.github/PULL_REQUEST_TEMPLATE.md:
##########
@@ -16,7 +16,8 @@ Thanks for sending a pull request!  Here are some tips for you:
 
 ### Does this PR resolve a correctness bug?
 
-<!-- Yes/No. (Note: If yes, committer will add `correctness` label to current pull request). -->
+<!-- Check if yes. The `correctness` label will be added/removed automatically. -->
+- [ ] Yes
 
 ### Does this PR introduce _any_ user-facing change?

Review Comment:
   Done, added the same `- [ ] Yes` checkbox to the user-facing change section.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] ci: auto-apply correctness label from PR template checkbox [celeborn]

Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei closed pull request #3688: ci: auto-apply correctness label from PR template checkbox
URL: https://github.com/apache/celeborn/pull/3688


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org