You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by RussellSpitzer <gi...@git.apache.org> on 2015/10/30 05:37:43 UTC

[GitHub] spark pull request: SPARK-11415: Remove timezone shift of Catalyst...

GitHub user RussellSpitzer opened a pull request:

    https://github.com/apache/spark/pull/9369

    SPARK-11415: Remove timezone shift of Catalyst DateType

    Shifting the timestamp before calculating the days since epoch was
    yielding off by one errors. Machines operating in different time zones
    would also yeild different results. Treating the input to millisToDays
    and daysToMillis as a straight UTC timestamp fixes this issue.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/RussellSpitzer/spark SPARK-11415

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/9369.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #9369
    
----
commit 53a6a14e58526b3f4f4160104be6f02c3751ecc5
Author: Russell Spitzer <ru...@gmail.com>
Date:   2015-10-30T04:34:11Z

    SPARK-11415: Remove timezone shift of Catalyst DateType
    
    Shifting the timestamp before calculating the days since epoch was
    yielding off by one errors. Machines operating in different time zones
    would also yeild different results. Treating the input to millisToDays
    and daysToMillis as a straight UTC timestamp fixes this issue.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: SPARK-11415: Remove timezone shift of Catalyst...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/9369#issuecomment-154877868
  
      [Test build #45318 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45318/consoleFull) for   PR 9369 at commit [`cc41a0c`](https://github.com/apache/spark/commit/cc41a0cac0085cc1857b958d76079b3de192be22).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org