[GitHub] [dubbo-go] flycash commented on a change in pull request #497: Implement event dispatch method

[GitBox <gi...@apache.org>]

flycash commented on a change in pull request #497:
URL: https://github.com/apache/dubbo-go/pull/497#discussion_r418562598



##########
File path: registry/nacos/service_discovery.go
##########
@@ -237,7 +237,7 @@ func (n *nacosServiceDiscovery) DispatchEventForInstances(serviceName string, in
 
 // DispatchEvent will dispatch the event
 func (n *nacosServiceDiscovery) DispatchEvent(event *registry.ServiceInstancesChangedEvent) error {
-	// TODO(waiting for event dispatcher, another task)
+	extension.GetGlobalDispatcher().Dispatch(event)

Review comment:
       Yes, but I think we could allow users to configure the dispatcher.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org