You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Oliver Szabo <os...@hortonworks.com> on 2016/01/12 13:14:13 UTC
Review Request 42189: StackAdvisor: ConcurrentModificationException
with blueprint provisioning
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42189/
-----------------------------------------------------------
Review request for Ambari, Robert Levas, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
Bugs: AMBARI-14611
https://issues.apache.org/jira/browse/AMBARI-14611
Repository: ambari
Description
-------
With ONLY_STACK_DEFAULTS_APPLY strategy, ConcurrentModificationException can thrown.
Changed some log levels too (can be more informative, to detect stack advisor issues)
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java f8221b5
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java ab6913e
Diff: https://reviews.apache.org/r/42189/diff/
Testing
-------
Total run:863
Total errors:0
Total failures:0
OK
INFO: AMBARI_SERVER_LIB is not set, using default /usr/lib/ambari-server
INFO: Return code from stack upgrade command, retcode = 0
log
log
StackAdvisor implementation for stack HDP1, version 2.0.6 was not found
Returning DefaultStackAdvisor implementation
StackAdvisor implementation for stack XYZ, version 1.0.0 was loaded
StackAdvisor implementation for stack XYZ, version 1.0.1 was loaded
Returning XYZ101StackAdvisor implementation
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1:15:07.935s
[INFO] Finished at: Tue Jan 12 12:52:04 CET 2016
[INFO] Final Memory: 45M/1071M
[INFO] ------------------------------------------------------------------------
Thanks,
Oliver Szabo
Re: Review Request 42189: StackAdvisor:
ConcurrentModificationException with blueprint provisioning
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42189/#review113984
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Levas
On Jan. 12, 2016, 9:11 a.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42189/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2016, 9:11 a.m.)
>
>
> Review request for Ambari, Robert Levas, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
>
>
> Bugs: AMBARI-14611
> https://issues.apache.org/jira/browse/AMBARI-14611
>
>
> Repository: ambari
>
>
> Description
> -------
>
> With ONLY_STACK_DEFAULTS_APPLY strategy, ConcurrentModificationException can thrown.
>
> Changed some log levels too (can be more informative, to detect stack advisor issues)
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java f8221b5
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java ab6913e
>
> Diff: https://reviews.apache.org/r/42189/diff/
>
>
> Testing
> -------
>
> Total run:863
> Total errors:0
> Total failures:0
> OK
> INFO: AMBARI_SERVER_LIB is not set, using default /usr/lib/ambari-server
> INFO: Return code from stack upgrade command, retcode = 0
> log
> log
> StackAdvisor implementation for stack HDP1, version 2.0.6 was not found
> Returning DefaultStackAdvisor implementation
> StackAdvisor implementation for stack XYZ, version 1.0.0 was loaded
> StackAdvisor implementation for stack XYZ, version 1.0.1 was loaded
> Returning XYZ101StackAdvisor implementation
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:15:07.935s
> [INFO] Finished at: Tue Jan 12 12:52:04 CET 2016
> [INFO] Final Memory: 45M/1071M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 42189: StackAdvisor:
ConcurrentModificationException with blueprint provisioning
Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42189/#review113988
-----------------------------------------------------------
Ship it!
Ship It!
- Sebastian Toader
On Jan. 12, 2016, 3:11 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42189/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2016, 3:11 p.m.)
>
>
> Review request for Ambari, Robert Levas, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
>
>
> Bugs: AMBARI-14611
> https://issues.apache.org/jira/browse/AMBARI-14611
>
>
> Repository: ambari
>
>
> Description
> -------
>
> With ONLY_STACK_DEFAULTS_APPLY strategy, ConcurrentModificationException can thrown.
>
> Changed some log levels too (can be more informative, to detect stack advisor issues)
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java f8221b5
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java ab6913e
>
> Diff: https://reviews.apache.org/r/42189/diff/
>
>
> Testing
> -------
>
> Total run:863
> Total errors:0
> Total failures:0
> OK
> INFO: AMBARI_SERVER_LIB is not set, using default /usr/lib/ambari-server
> INFO: Return code from stack upgrade command, retcode = 0
> log
> log
> StackAdvisor implementation for stack HDP1, version 2.0.6 was not found
> Returning DefaultStackAdvisor implementation
> StackAdvisor implementation for stack XYZ, version 1.0.0 was loaded
> StackAdvisor implementation for stack XYZ, version 1.0.1 was loaded
> Returning XYZ101StackAdvisor implementation
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:15:07.935s
> [INFO] Finished at: Tue Jan 12 12:52:04 CET 2016
> [INFO] Final Memory: 45M/1071M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 42189: StackAdvisor:
ConcurrentModificationException with blueprint provisioning
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42189/
-----------------------------------------------------------
(Updated Jan. 12, 2016, 2:11 p.m.)
Review request for Ambari, Robert Levas, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
Changes
-------
updated test inputs
Bugs: AMBARI-14611
https://issues.apache.org/jira/browse/AMBARI-14611
Repository: ambari
Description
-------
With ONLY_STACK_DEFAULTS_APPLY strategy, ConcurrentModificationException can thrown.
Changed some log levels too (can be more informative, to detect stack advisor issues)
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java f8221b5
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java ab6913e
Diff: https://reviews.apache.org/r/42189/diff/
Testing
-------
Total run:863
Total errors:0
Total failures:0
OK
INFO: AMBARI_SERVER_LIB is not set, using default /usr/lib/ambari-server
INFO: Return code from stack upgrade command, retcode = 0
log
log
StackAdvisor implementation for stack HDP1, version 2.0.6 was not found
Returning DefaultStackAdvisor implementation
StackAdvisor implementation for stack XYZ, version 1.0.0 was loaded
StackAdvisor implementation for stack XYZ, version 1.0.1 was loaded
Returning XYZ101StackAdvisor implementation
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1:15:07.935s
[INFO] Finished at: Tue Jan 12 12:52:04 CET 2016
[INFO] Final Memory: 45M/1071M
[INFO] ------------------------------------------------------------------------
Thanks,
Oliver Szabo
Re: Review Request 42189: StackAdvisor:
ConcurrentModificationException with blueprint provisioning
Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42189/#review113979
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java (line 447)
<https://reviews.apache.org/r/42189/#comment174772>
Please try to create a unit test that reproduces this error.
- Sebastian Toader
On Jan. 12, 2016, 1:14 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42189/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2016, 1:14 p.m.)
>
>
> Review request for Ambari, Robert Levas, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
>
>
> Bugs: AMBARI-14611
> https://issues.apache.org/jira/browse/AMBARI-14611
>
>
> Repository: ambari
>
>
> Description
> -------
>
> With ONLY_STACK_DEFAULTS_APPLY strategy, ConcurrentModificationException can thrown.
>
> Changed some log levels too (can be more informative, to detect stack advisor issues)
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java f8221b5
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java ab6913e
>
> Diff: https://reviews.apache.org/r/42189/diff/
>
>
> Testing
> -------
>
> Total run:863
> Total errors:0
> Total failures:0
> OK
> INFO: AMBARI_SERVER_LIB is not set, using default /usr/lib/ambari-server
> INFO: Return code from stack upgrade command, retcode = 0
> log
> log
> StackAdvisor implementation for stack HDP1, version 2.0.6 was not found
> Returning DefaultStackAdvisor implementation
> StackAdvisor implementation for stack XYZ, version 1.0.0 was loaded
> StackAdvisor implementation for stack XYZ, version 1.0.1 was loaded
> Returning XYZ101StackAdvisor implementation
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:15:07.935s
> [INFO] Finished at: Tue Jan 12 12:52:04 CET 2016
> [INFO] Final Memory: 45M/1071M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Oliver Szabo
>
>