You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2021/02/18 10:06:31 UTC
[GitHub] [kylin] zhengshengjun opened a new pull request #1585: KYLIN-4906 Support query/job server dynamic register and discovery in kylin4
zhengshengjun opened a new pull request #1585:
URL: https://github.com/apache/kylin/pull/1585
… kylin4
(cherry picked from commit fa37255b15bdf69e347ec747baf0731ce6634b39)
(cherry picked from commit fa37255b15bdf69e347ec747baf0731ce6634b39)
(cherry picked from commit fa37255b15bdf69e347ec747baf0731ce6634b39)
## Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
## Types of changes
What types of changes does your code introduce to Kylin?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [x] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail
- [x] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
- [x] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If this change need a document change, I will prepare another pr against the `document` branch
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] zhangayqian commented on a change in pull request #1585: KYLIN-4906 Support query/job server dynamic register and discovery in kylin4
Posted by GitBox <gi...@apache.org>.
zhangayqian commented on a change in pull request #1585:
URL: https://github.com/apache/kylin/pull/1585#discussion_r578983496
##########
File path: core-common/pom.xml
##########
@@ -49,6 +49,12 @@
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.apache.curator</groupId>
+ <artifactId>curator-x-discovery</artifactId>
+ <!-- this jar was absent from hbase lib, so compile it -->
Review comment:
This comment can be deleted. Because kylin4 is removing hbase dependency.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] codecov-io edited a comment on pull request #1585: KYLIN-4906 Support query/job server dynamic register and discovery in kylin4
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1585:
URL: https://github.com/apache/kylin/pull/1585#issuecomment-781874343
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1585?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`kylin-on-parquet-v2@b428f1e`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/kylin/pull/1585?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## kylin-on-parquet-v2 #1585 +/- ##
======================================================
Coverage ? 24.36%
Complexity ? 4649
======================================================
Files ? 1145
Lines ? 65335
Branches ? 9595
======================================================
Hits ? 15917
Misses ? 47754
Partials ? 1664
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1585?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1585?src=pr&el=footer). Last update [b428f1e...3f9dd29](https://codecov.io/gh/apache/kylin/pull/1585?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus merged pull request #1585: KYLIN-4906 Support query/job server dynamic register and discovery in kylin4
Posted by GitBox <gi...@apache.org>.
hit-lacus merged pull request #1585:
URL: https://github.com/apache/kylin/pull/1585
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] zhengshengjun commented on a change in pull request #1585: KYLIN-4906 Support query/job server dynamic register and discovery in kylin4
Posted by GitBox <gi...@apache.org>.
zhengshengjun commented on a change in pull request #1585:
URL: https://github.com/apache/kylin/pull/1585#discussion_r579576534
##########
File path: core-common/pom.xml
##########
@@ -49,6 +49,12 @@
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.apache.curator</groupId>
+ <artifactId>curator-x-discovery</artifactId>
+ <!-- this jar was absent from hbase lib, so compile it -->
Review comment:
thanks for reviewing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus commented on pull request #1585: KYLIN-4906 Support query/job server dynamic register and discovery in kylin4
Posted by GitBox <gi...@apache.org>.
hit-lacus commented on pull request #1585:
URL: https://github.com/apache/kylin/pull/1585#issuecomment-783128322
This patch looks to me, will merge. Maybe we should update the offical document about JobScheduler, @zhangayqian could you please add a question and answer in https://cwiki.apache.org/confluence/display/KYLIN/FAQ+Kylin+4.X ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] codecov-io commented on pull request #1585: KYLIN-4906 Support query/job server dynamic register and discovery in kylin4
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1585:
URL: https://github.com/apache/kylin/pull/1585#issuecomment-781874343
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1585?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`kylin-on-parquet-v2@b428f1e`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/kylin/pull/1585?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## kylin-on-parquet-v2 #1585 +/- ##
======================================================
Coverage ? 24.35%
Complexity ? 4649
======================================================
Files ? 1145
Lines ? 65335
Branches ? 9595
======================================================
Hits ? 15914
Misses ? 47756
Partials ? 1665
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1585?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1585?src=pr&el=footer). Last update [b428f1e...51f1ff5](https://codecov.io/gh/apache/kylin/pull/1585?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org