[GitHub] [incubator-superset] etr2460 commented on a change in pull request #7977: [DB Engine] Support old and new Presto syntax

[GitBox <gi...@apache.org>]

etr2460 commented on a change in pull request #7977: [DB Engine] Support old and new Presto syntax
URL: https://github.com/apache/incubator-superset/pull/7977#discussion_r310292369
 
 

 ##########
 File path: superset/db_engine_specs/presto.py
 ##########
 @@ -29,13 +29,16 @@
 from sqlalchemy.engine.result import RowProxy
 from sqlalchemy.sql.expression import ColumnClause
 
+from superset import app
 from superset.db_engine_specs.base import BaseEngineSpec
 from superset.exceptions import SupersetTemplateException
 from superset.models.sql_types.presto_sql_types import type_map as presto_type_map
 from superset.utils import core as utils
 
 QueryStatus = utils.QueryStatus
 
+PRESTO_VERSION = app.config.get("PRESTO_VERSION")
 
 Review comment:
   Eek, that's true... This should be added to the database model

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org