[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #11206: feat: home screen mvp

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #11206:
URL: https://github.com/apache/incubator-superset/pull/11206#discussion_r510295852



##########
File path: superset-frontend/src/components/ListViewCard/index.tsx
##########
@@ -139,19 +139,39 @@ const SkeletonActions = styled(Skeleton.Button)`
   width: ${({ theme }) => theme.gridUnit * 10}px;
 `;
 
+const QueryData = styled.div`
+  display: flex;
+  flex-direction: row;
+  justify-content: flex-start;
+  border-bottom: 1px solid #e0e0e0;
+  .title {
+    font-weight: 500;
+    color: #b2b2b2;
+  }
+  .holder {
+    margin: 10px 10px 10px 10px;
+  }
+`;
+
 const paragraphConfig = { rows: 1, width: 150 };
 interface CardProps {
   title: React.ReactNode;
   url?: string;
   imgURL: string;
+  tables?: string | number;
   imgFallbackURL: string;
   imgPosition?: BackgroundPosition;
   description: string;
   loading: boolean;
   titleRight?: React.ReactNode;
   coverLeft?: React.ReactNode;
   coverRight?: React.ReactNode;
-  actions: React.ReactNode;
+  actions: React.ReactNode | null;
+  showImg?: boolean;
+  rows?: number | string;
+  avatar?: string;
+  isRecent?: boolean;
+  tableName?: string;
 }
 
 function ListViewCard({

Review comment:
       It's super late into this project to do component modeling! We should have done component modeling at the very beginning and figure out which component we'll alter and the ones we'll create / refactor.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org