You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "lliangyu-lin (via GitHub)" <gi...@apache.org> on 2025/05/12 22:26:39 UTC
[PR] feat: Implement remove properties CLI using catalog commit table API and improve references [iceberg-go]
lliangyu-lin opened a new pull request, #429:
URL: https://github.com/apache/iceberg-go/pull/429
### Description
* Close the gap in properties CLI using the commit table implementation
* Update references and loggings as mentioned in #424
### Testing
```
go run . properties get table lliangyu_test_db.tbl1 --catalog glue
┌──────────────┐
| Key | Value |
| ------------ |
| key1 | val1 |
└──────────────┘
go run . properties set table lliangyu_test_db.tbl1 write.object-storage.enabled true --catalog glue
Setting write.object-storage.enabled=true on lliangyu_test_db.tbl1
Updated write.object-storage.enabled on lliangyu_test_db.tbl1
go run . properties get table lliangyu_test_db.tbl1 --catalog glue
┌──────────────────────────────────────┐
| Key | Value |
| ------------------------------------ |
| key1 | val1 |
| write.object-storage.enabled | true |
└──────────────────────────────────────┘
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat: Implement remove properties CLI using catalog commit table API and improve references [iceberg-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #429:
URL: https://github.com/apache/iceberg-go/pull/429
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat: Implement remove properties CLI using catalog commit table API and improve references [iceberg-go]
Posted by "lliangyu-lin (via GitHub)" <gi...@apache.org>.
lliangyu-lin commented on code in PR #429:
URL: https://github.com/apache/iceberg-go/pull/429#discussion_r2085621667
##########
README.md:
##########
@@ -70,9 +70,9 @@ $ cd iceberg-go/cmd/iceberg && go build .
| Create New Snapshot | X | | | | X |
| Rename Table | X | | | X | X |
| Drop Table | X | | | X | X |
-| Alter Table | X | | | | X |
+| Alter Table | X | | | X | X |
| Check Table Exists | X | | | X | X |
-| Set Table Properties | X | | | | X |
+| Set Table Properties | X | | | X | X |
Review Comment:
This was missed in Glue catalog commit table implementation [PR](https://github.com/apache/iceberg-go/pull/403)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org