You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/08/16 13:41:33 UTC
[GitHub] [dubbo] changfubai opened a new pull request #8520: fix Issue 8516
changfubai opened a new pull request #8520:
URL: https://github.com/apache/dubbo/pull/8520
see: #8516
complete test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] 24kpure commented on pull request #8520: fix Issue 8516
Posted by GitBox <gi...@apache.org>.
24kpure commented on pull request #8520:
URL: https://github.com/apache/dubbo/pull/8520#issuecomment-901814655
Why not merge 5 commit into one？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] 24kpure commented on pull request #8520: fix Issue 8516
Posted by GitBox <gi...@apache.org>.
24kpure commented on pull request #8520:
URL: https://github.com/apache/dubbo/pull/8520#issuecomment-901821535
> ## What is the purpose of the change
> fix #8513
fix #8516 ？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ commented on pull request #8520: fix Issue 8516 on branch 2.7-native_image
Posted by GitBox <gi...@apache.org>.
AlbumenJ commented on pull request #8520:
URL: https://github.com/apache/dubbo/pull/8520#issuecomment-903455811
`2.7-native_image` branch is deprecated. Those changes have been merge into master(2.7.x) and 3.0 branch. Please check if our mainline branch have the same problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] 24kpure removed a comment on pull request #8520: fix Issue 8516
Posted by GitBox <gi...@apache.org>.
24kpure removed a comment on pull request #8520:
URL: https://github.com/apache/dubbo/pull/8520#issuecomment-901814655
Why not merge 5 commit into one？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] changfubai commented on pull request #8520: fix Issue 8516
Posted by GitBox <gi...@apache.org>.
changfubai commented on pull request #8520:
URL: https://github.com/apache/dubbo/pull/8520#issuecomment-901875532
> > ## What is the purpose of the change
> > fix #8513
> > fix #8516 ？
sorry, that was a slip of the pen. just fixed #8516
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] changfubai edited a comment on pull request #8520: fix Issue 8516 on branch 2.7-native_image
Posted by GitBox <gi...@apache.org>.
changfubai edited a comment on pull request #8520:
URL: https://github.com/apache/dubbo/pull/8520#issuecomment-902717538
> > thanks!! I'll try it. By the way, fix bug in master branch, then when to fix in old branch?
>
> Fix the bug of the 2.7 branch (that is master) first, and then check whether this problem also exists in the 3.0 branch. After this fix, also check whether the 2.6.x version also has this problem.
I submit to master branch and 3.0 branch. could you please help me review? #8558 #8554
by the way, should i submit this commit to all the branches if this bug exist on the all?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] changfubai commented on pull request #8520: fix Issue 8516 on branch 2.7-native_image
Posted by GitBox <gi...@apache.org>.
changfubai commented on pull request #8520:
URL: https://github.com/apache/dubbo/pull/8520#issuecomment-902832853
2.7-native_image这个分支本身单测就过不了啊 -。-
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] BazookaW commented on pull request #8520: fix Issue 8516
Posted by GitBox <gi...@apache.org>.
BazookaW commented on pull request #8520:
URL: https://github.com/apache/dubbo/pull/8520#issuecomment-900989924
> by the way, is it ok to commit to the branch `apache:2.7-native_image` ?
目前3.0是最新分支哈
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] changfubai edited a comment on pull request #8520: fix Issue 8516
Posted by GitBox <gi...@apache.org>.
changfubai edited a comment on pull request #8520:
URL: https://github.com/apache/dubbo/pull/8520#issuecomment-901874504
> 
> @changfubai 帮你看了一下，应该是这个问题。你可以去guide上找一个code style，然后本地代码格式化一下试试哈 https://github.com/apache/dubbo/blob/master/codestyle/dubbo_codestyle_for_idea.xml。
谢谢大佬，我试试！！
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] changfubai edited a comment on pull request #8520: fix Issue 8516
Posted by GitBox <gi...@apache.org>.
changfubai edited a comment on pull request #8520:
URL: https://github.com/apache/dubbo/pull/8520#issuecomment-899522583
by the way, is it ok to commit to the branch `apache:2.7-native_image` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] BazookaW edited a comment on pull request #8520: fix Issue 8516
Posted by GitBox <gi...@apache.org>.
BazookaW edited a comment on pull request #8520:
URL: https://github.com/apache/dubbo/pull/8520#issuecomment-900989696
@changfubai 帮你看了一下，应该是这个问题。你可以去guide上找一个code style，然后本地代码格式化一下试试哈 [https://github.com/apache/dubbo/blob/master/codestyle/dubbo_codestyle_for_idea.xml](https://github.com/apache/dubbo/blob/master/codestyle/dubbo_codestyle_for_idea.xml)。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] changfubai commented on pull request #8520: fix Issue 8516
Posted by GitBox <gi...@apache.org>.
changfubai commented on pull request #8520:
URL: https://github.com/apache/dubbo/pull/8520#issuecomment-899522583
by the way, is ok to commit to the branch `apache:2.7-native_image` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] changfubai edited a comment on pull request #8520: fix Issue 8516
Posted by GitBox <gi...@apache.org>.
changfubai edited a comment on pull request #8520:
URL: https://github.com/apache/dubbo/pull/8520#issuecomment-901874504
> 
> @changfubai 帮你看了一下，应该是这个问题。你可以去guide上找一个code style，然后本地代码格式化一下试试哈 https://github.com/apache/dubbo/blob/master/codestyle/dubbo_codestyle_for_idea.xml。
谢谢大佬，我试试！！
另外，这个本地要执行这个check用什么命令呢？ mvn clean package ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] BazookaW commented on pull request #8520: fix Issue 8516
Posted by GitBox <gi...@apache.org>.
BazookaW commented on pull request #8520:
URL: https://github.com/apache/dubbo/pull/8520#issuecomment-900989696
@changfubai 帮你看了一下，应该是这个问题
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ closed pull request #8520: fix Issue 8516 on branch 2.7-native_image
Posted by GitBox <gi...@apache.org>.
AlbumenJ closed pull request #8520:
URL: https://github.com/apache/dubbo/pull/8520
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] changfubai edited a comment on pull request #8520: fix Issue 8516 on branch 2.7-native_image
Posted by GitBox <gi...@apache.org>.
changfubai edited a comment on pull request #8520:
URL: https://github.com/apache/dubbo/pull/8520#issuecomment-902717538
> > thanks!! I'll try it. By the way, fix bug in master branch, then when to fix in old branch?
>
> Fix the bug of the 2.7 branch (that is master) first, and then check whether this problem also exists in the 3.0 branch. After this fix, also check whether the 2.6.x version also has this problem.
I submit to master branch and 3.0 branch. could you please help me revirew? #8558 #8554
by the way, should i submit this commit to all the branches if this bug exist on the all?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] xiaoheng1 commented on pull request #8520: fix Issue 8516
Posted by GitBox <gi...@apache.org>.
xiaoheng1 commented on pull request #8520:
URL: https://github.com/apache/dubbo/pull/8520#issuecomment-901946476
> thanks!! I'll try it. By the way, fix bug in master branch, then when to fix in old branch?
Fix the bug of the 2.7 branch (that is master) first, and then check whether this problem also exists in the 3.0 branch. After this fix, also check whether the 2.6.x version also has this problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] changfubai commented on pull request #8520: fix Issue 8516
Posted by GitBox <gi...@apache.org>.
changfubai commented on pull request #8520:
URL: https://github.com/apache/dubbo/pull/8520#issuecomment-901874504
> 
> @changfubai 帮你看了一下，应该是这个问题。你可以去guide上找一个code style，然后本地代码格式化一下试试哈 https://github.com/apache/dubbo/blob/master/codestyle/dubbo_codestyle_for_idea.xml。
谢谢大佬，我试试！！
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] changfubai commented on pull request #8520: fix Issue 8516
Posted by GitBox <gi...@apache.org>.
changfubai commented on pull request #8520:
URL: https://github.com/apache/dubbo/pull/8520#issuecomment-901877340
> please fix ut.
>
> also, this should be submitted to the master branch. By the way, help to see if this problem exists in the 3.0 branch please.
>
> common/compiler/support/JdkCompiler.java:40:8: Unused import - java.nio.file.Files. [UnusedImports]
thanks!! I'll try it. By the way, fix bug in master branch, then when to fix in old branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] BazookaW edited a comment on pull request #8520: fix Issue 8516
Posted by GitBox <gi...@apache.org>.
BazookaW edited a comment on pull request #8520:
URL: https://github.com/apache/dubbo/pull/8520#issuecomment-900989696
@changfubai 帮你看了一下，应该是这个问题。你可以去guide上找一个code style，然后本地代码格式化一下试试哈 [https://github.com/apache/dubbo/blob/master/codestyle/dubbo_codestyle_for_idea.xml](https://github.com/apache/dubbo/blob/master/codestyle/dubbo_codestyle_for_idea.xml)。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] changfubai commented on pull request #8520: fix Issue 8516 on branch 2.7-native_image
Posted by GitBox <gi...@apache.org>.
changfubai commented on pull request #8520:
URL: https://github.com/apache/dubbo/pull/8520#issuecomment-902717538
> > thanks!! I'll try it. By the way, fix bug in master branch, then when to fix in old branch?
>
> Fix the bug of the 2.7 branch (that is master) first, and then check whether this problem also exists in the 3.0 branch. After this fix, also check whether the 2.6.x version also has this problem.
I submit to master branch and 3.0 branch. could you please help me revirew?
by the way, should i submit this commit to all the branches if this bug exist on the all?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] BazookaW commented on pull request #8520: fix Issue 8516
Posted by GitBox <gi...@apache.org>.
BazookaW commented on pull request #8520:
URL: https://github.com/apache/dubbo/pull/8520#issuecomment-900989696
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org