You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by ro...@apache.org on 2006/01/08 05:48:51 UTC
svn commit: r366985 -
/httpd/httpd/branches/fcgi-proxy-dev/modules/proxy/mod_proxy_fcgi.c
Author: rooneg
Date: Sat Jan 7 20:48:50 2006
New Revision: 366985
URL: http://svn.apache.org/viewcvs?rev=366985&view=rev
Log:
In theory, we now correctly implement all of the FastCGI protocol, so
there's no reason that request ids wouldn't be matching up. Until we
see an example of a request id mismatch error that is absolutely not
caused by an error in our parsing of the FastCGI protocol, we should
be able to go back to treating mismatches as errors.
* modules/proxy/mod_proxy_fcgi.c
(dispatch): Remove #ifdef that turned off treating rid mismatches as
fatal errors.
Modified:
httpd/httpd/branches/fcgi-proxy-dev/modules/proxy/mod_proxy_fcgi.c
Modified: httpd/httpd/branches/fcgi-proxy-dev/modules/proxy/mod_proxy_fcgi.c
URL: http://svn.apache.org/viewcvs/httpd/httpd/branches/fcgi-proxy-dev/modules/proxy/mod_proxy_fcgi.c?rev=366985&r1=366984&r2=366985&view=diff
==============================================================================
--- httpd/httpd/branches/fcgi-proxy-dev/modules/proxy/mod_proxy_fcgi.c (original)
+++ httpd/httpd/branches/fcgi-proxy-dev/modules/proxy/mod_proxy_fcgi.c Sat Jan 7 20:48:50 2006
@@ -502,10 +502,8 @@
ap_log_error(APLOG_MARK, APLOG_ERR, 0, r->server,
"proxy: FCGI: Got bogus rid %d, expected %d",
rid, request_id);
-#if defined(RID_MISMATCH_IS_TERMINAL_ERROR)
rv = APR_EINVAL;
break;
-#endif
}
clen = header[FCGI_HDR_CONTENT_LEN_B1_OFFSET] << 8;
Re: svn commit: r366985 - /httpd/httpd/branches/fcgi-proxy-dev/modules/proxy/mod_proxy_fcgi.c
Posted by Garrett Rooney <ro...@electricjellyfish.net>.
On 1/7/06, rooneg@apache.org <ro...@apache.org> wrote:
> Author: rooneg
> Date: Sat Jan 7 20:48:50 2006
> New Revision: 366985
>
> URL: http://svn.apache.org/viewcvs?rev=366985&view=rev
> Log:
> In theory, we now correctly implement all of the FastCGI protocol, so
> there's no reason that request ids wouldn't be matching up. Until we
> see an example of a request id mismatch error that is absolutely not
> caused by an error in our parsing of the FastCGI protocol, we should
> be able to go back to treating mismatches as errors.
>
> * modules/proxy/mod_proxy_fcgi.c
> (dispatch): Remove #ifdef that turned off treating rid mismatches as
> fatal errors.
Jim, if you're still seeing these kind of problems let me know. I'm
pretty sure we should have fixed up any issues that would result in
those kind of mismatches at this point, but if not I'd love to know
what fcgi library you're using and what you made it do to get the
errors...
-garrett