[GitHub] [spark] c21 commented on a change in pull request #33987: [SPARK-36705][SHUFFLE][FOLLOWUP] Avoid unnecessary logging for checking push-based shuffle

[GitBox <gi...@apache.org>]

c21 commented on a change in pull request #33987:
URL: https://github.com/apache/spark/pull/33987#discussion_r707870619



##########
File path: core/src/main/scala/org/apache/spark/util/Utils.scala
##########
@@ -2604,23 +2604,27 @@ private[spark] object Utils extends Logging {
    *   - serializer(such as KryoSerializer) supports relocation of serialized objects
    */
   def isPushBasedShuffleEnabled(conf: SparkConf): Boolean = {
-    val serializer = Utils.classForName(conf.get(SERIALIZER)).getConstructor(classOf[SparkConf])
-      .newInstance(conf).asInstanceOf[Serializer]
-    val canDoPushBasedShuffle =
-      conf.get(PUSH_BASED_SHUFFLE_ENABLED) &&
-        (conf.get(IS_TESTING).getOrElse(false) ||
-          (conf.get(SHUFFLE_SERVICE_ENABLED) &&
-            conf.get(SparkLauncher.SPARK_MASTER, null) == "yarn" &&
-            // TODO: [SPARK-36744] needs to support IO encryption for push-based shuffle
-            !conf.get(IO_ENCRYPTION_ENABLED) &&
-            serializer.supportsRelocationOfSerializedObjects))
-
-    if (!canDoPushBasedShuffle) {
-      logWarning("Push-based shuffle can only be enabled when the application is submitted" +

Review comment:
       It also missed two spaces in "submitted to" and "and relocation". Just fixed it as well.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org