You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/07/30 22:30:01 UTC

[GitHub] [superset] graceguo-supercat commented on a change in pull request #15993: fix(dashboard): FilterBox JS error when datasets API is slow

graceguo-supercat commented on a change in pull request #15993:
URL: https://github.com/apache/superset/pull/15993#discussion_r680250867



##########
File path: superset-frontend/src/chart/ChartRenderer.jsx
##########
@@ -93,7 +94,7 @@ class ChartRenderer extends React.Component {
         nextProps.queriesResponse !== this.props.queriesResponse;
       return (
         this.hasQueryResponseChange ||
-        nextProps.datasource !== this.props.datasource ||
+        !isEqual(nextProps.datasource, this.props.datasource) ||

Review comment:
       👍 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org