[GitHub] [madlib] hpandeycodeit commented on a change in pull request #398: Updated the code, state_size was pointing to the wrong value

[GitBox <gi...@apache.org>]

hpandeycodeit commented on a change in pull request #398: Updated the code, state_size was pointing to the wrong value
URL: https://github.com/apache/madlib/pull/398#discussion_r288653218
 
 

 ##########
 File path: src/ports/postgres/modules/convex/mlp_igd.py_in
 ##########
 @@ -334,7 +334,7 @@ def mlp(schema_madlib, source_table, output_table, independent_varname,
                         """
                 it.update(train_sql)
                 if it_args['state_size'] == -1:
-                    it_args['state_size'] = it.get_state_size()
+                    it.kwargs['state_size'] = it.get_state_size()
 
 Review comment:
   Thanks for pointing it out! Yeah, I missed correcting the `if condition` here. Fixed it now.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services