You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@iceberg.apache.org by Amogh Jahagirdar <2a...@gmail.com> on 2024/08/13 15:08:12 UTC

[VOTE] Merge REST spec clarification on how servers should handle unknown updates/requirements

I've opened a PR [1] to clarify in the REST spec that if a server
receives an unknown update or requirement as part of any the commit
endpoints, that the server must fail with a 400 error response.

Please vote on merging this change.  The vote will remain open for at least
72 hours.

[] +1
[] +0
[] -1, do not merge because ...

[1] https://github.com/apache/iceberg/pull/10848

Thanks,

Amogh Jahagirdar

Re: [VOTE] Merge REST spec clarification on how servers should handle unknown updates/requirements

Posted by Amogh Jahagirdar <2a...@gmail.com>.
The vote passes 7 +1 binding votes and 1 +1 non-binding vote and I will
merge the spec change.
Thanks everyone for providing feedback and voting!

Thanks,
Amogh Jahagirdar


On Wed, Aug 14, 2024 at 9:23 PM Renjie Liu <li...@gmail.com> wrote:

> +1
>
> On Thu, Aug 15, 2024 at 10:10 AM Jack Ye <ye...@gmail.com> wrote:
>
>> +1
>>
>> -Jack
>>
>> On Wed, Aug 14, 2024 at 8:39 AM Daniel Weeks <dw...@apache.org> wrote:
>>
>>> +1
>>>
>>> On Tue, Aug 13, 2024 at 7:34 PM xianjin <xi...@apache.org> wrote:
>>>
>>>> +1
>>>>
>>>> On Aug 14, 2024, at 2:24 AM, Ryan Blue <bl...@databricks.com.invalid>
>>>> wrote:
>>>>
>>>> 
>>>> +1
>>>>
>>>> On Tue, Aug 13, 2024 at 8:59 AM Yufei Gu <fl...@gmail.com> wrote:
>>>>
>>>>> +1
>>>>> Yufei
>>>>>
>>>>>
>>>>> On Tue, Aug 13, 2024 at 8:57 AM Eduard Tudenhöfner <
>>>>> etudenhoefner@apache.org> wrote:
>>>>>
>>>>>> +1
>>>>>>
>>>>>> On Tue, Aug 13, 2024 at 5:09 PM Amogh Jahagirdar <2a...@gmail.com>
>>>>>> wrote:
>>>>>>
>>>>>>> I've opened a PR [1] to clarify in the REST spec that if a server
>>>>>>> receives an unknown update or requirement as part of any the commit
>>>>>>> endpoints, that the server must fail with a 400 error response.
>>>>>>>
>>>>>>> Please vote on merging this change.  The vote will remain open for
>>>>>>> at least 72 hours.
>>>>>>>
>>>>>>> [] +1
>>>>>>> [] +0
>>>>>>> [] -1, do not merge because ...
>>>>>>>
>>>>>>> [1] https://github.com/apache/iceberg/pull/10848
>>>>>>>
>>>>>>> Thanks,
>>>>>>>
>>>>>>> Amogh Jahagirdar
>>>>>>>
>>>>>>
>>>>
>>>> --
>>>> Ryan Blue
>>>> Databricks
>>>>
>>>>

Re: [VOTE] Merge REST spec clarification on how servers should handle unknown updates/requirements

Posted by Renjie Liu <li...@gmail.com>.
+1

On Thu, Aug 15, 2024 at 10:10 AM Jack Ye <ye...@gmail.com> wrote:

> +1
>
> -Jack
>
> On Wed, Aug 14, 2024 at 8:39 AM Daniel Weeks <dw...@apache.org> wrote:
>
>> +1
>>
>> On Tue, Aug 13, 2024 at 7:34 PM xianjin <xi...@apache.org> wrote:
>>
>>> +1
>>>
>>> On Aug 14, 2024, at 2:24 AM, Ryan Blue <bl...@databricks.com.invalid>
>>> wrote:
>>>
>>> 
>>> +1
>>>
>>> On Tue, Aug 13, 2024 at 8:59 AM Yufei Gu <fl...@gmail.com> wrote:
>>>
>>>> +1
>>>> Yufei
>>>>
>>>>
>>>> On Tue, Aug 13, 2024 at 8:57 AM Eduard Tudenhöfner <
>>>> etudenhoefner@apache.org> wrote:
>>>>
>>>>> +1
>>>>>
>>>>> On Tue, Aug 13, 2024 at 5:09 PM Amogh Jahagirdar <2a...@gmail.com>
>>>>> wrote:
>>>>>
>>>>>> I've opened a PR [1] to clarify in the REST spec that if a server
>>>>>> receives an unknown update or requirement as part of any the commit
>>>>>> endpoints, that the server must fail with a 400 error response.
>>>>>>
>>>>>> Please vote on merging this change.  The vote will remain open for at
>>>>>> least 72 hours.
>>>>>>
>>>>>> [] +1
>>>>>> [] +0
>>>>>> [] -1, do not merge because ...
>>>>>>
>>>>>> [1] https://github.com/apache/iceberg/pull/10848
>>>>>>
>>>>>> Thanks,
>>>>>>
>>>>>> Amogh Jahagirdar
>>>>>>
>>>>>
>>>
>>> --
>>> Ryan Blue
>>> Databricks
>>>
>>>

Re: [VOTE] Merge REST spec clarification on how servers should handle unknown updates/requirements

Posted by Jack Ye <ye...@gmail.com>.
+1

-Jack

On Wed, Aug 14, 2024 at 8:39 AM Daniel Weeks <dw...@apache.org> wrote:

> +1
>
> On Tue, Aug 13, 2024 at 7:34 PM xianjin <xi...@apache.org> wrote:
>
>> +1
>>
>> On Aug 14, 2024, at 2:24 AM, Ryan Blue <bl...@databricks.com.invalid>
>> wrote:
>>
>> 
>> +1
>>
>> On Tue, Aug 13, 2024 at 8:59 AM Yufei Gu <fl...@gmail.com> wrote:
>>
>>> +1
>>> Yufei
>>>
>>>
>>> On Tue, Aug 13, 2024 at 8:57 AM Eduard Tudenhöfner <
>>> etudenhoefner@apache.org> wrote:
>>>
>>>> +1
>>>>
>>>> On Tue, Aug 13, 2024 at 5:09 PM Amogh Jahagirdar <2a...@gmail.com>
>>>> wrote:
>>>>
>>>>> I've opened a PR [1] to clarify in the REST spec that if a server
>>>>> receives an unknown update or requirement as part of any the commit
>>>>> endpoints, that the server must fail with a 400 error response.
>>>>>
>>>>> Please vote on merging this change.  The vote will remain open for at
>>>>> least 72 hours.
>>>>>
>>>>> [] +1
>>>>> [] +0
>>>>> [] -1, do not merge because ...
>>>>>
>>>>> [1] https://github.com/apache/iceberg/pull/10848
>>>>>
>>>>> Thanks,
>>>>>
>>>>> Amogh Jahagirdar
>>>>>
>>>>
>>
>> --
>> Ryan Blue
>> Databricks
>>
>>

Re: [VOTE] Merge REST spec clarification on how servers should handle unknown updates/requirements

Posted by Daniel Weeks <dw...@apache.org>.
+1

On Tue, Aug 13, 2024 at 7:34 PM xianjin <xi...@apache.org> wrote:

> +1
>
> On Aug 14, 2024, at 2:24 AM, Ryan Blue <bl...@databricks.com.invalid>
> wrote:
>
> 
> +1
>
> On Tue, Aug 13, 2024 at 8:59 AM Yufei Gu <fl...@gmail.com> wrote:
>
>> +1
>> Yufei
>>
>>
>> On Tue, Aug 13, 2024 at 8:57 AM Eduard Tudenhöfner <
>> etudenhoefner@apache.org> wrote:
>>
>>> +1
>>>
>>> On Tue, Aug 13, 2024 at 5:09 PM Amogh Jahagirdar <2a...@gmail.com>
>>> wrote:
>>>
>>>> I've opened a PR [1] to clarify in the REST spec that if a server
>>>> receives an unknown update or requirement as part of any the commit
>>>> endpoints, that the server must fail with a 400 error response.
>>>>
>>>> Please vote on merging this change.  The vote will remain open for at
>>>> least 72 hours.
>>>>
>>>> [] +1
>>>> [] +0
>>>> [] -1, do not merge because ...
>>>>
>>>> [1] https://github.com/apache/iceberg/pull/10848
>>>>
>>>> Thanks,
>>>>
>>>> Amogh Jahagirdar
>>>>
>>>
>
> --
> Ryan Blue
> Databricks
>
>

Re: [VOTE] Merge REST spec clarification on how servers should handle unknown updates/requirements

Posted by Fokko Driesprong <fo...@apache.org>.
+1

Thanks for clarifying this

Kind regards,
Fokko

Op wo 14 aug 2024 om 04:34 schreef xianjin <xi...@apache.org>:

> +1
>
> On Aug 14, 2024, at 2:24 AM, Ryan Blue <bl...@databricks.com.invalid>
> wrote:
>
> 
> +1
>
> On Tue, Aug 13, 2024 at 8:59 AM Yufei Gu <fl...@gmail.com> wrote:
>
>> +1
>> Yufei
>>
>>
>> On Tue, Aug 13, 2024 at 8:57 AM Eduard Tudenhöfner <
>> etudenhoefner@apache.org> wrote:
>>
>>> +1
>>>
>>> On Tue, Aug 13, 2024 at 5:09 PM Amogh Jahagirdar <2a...@gmail.com>
>>> wrote:
>>>
>>>> I've opened a PR [1] to clarify in the REST spec that if a server
>>>> receives an unknown update or requirement as part of any the commit
>>>> endpoints, that the server must fail with a 400 error response.
>>>>
>>>> Please vote on merging this change.  The vote will remain open for at
>>>> least 72 hours.
>>>>
>>>> [] +1
>>>> [] +0
>>>> [] -1, do not merge because ...
>>>>
>>>> [1] https://github.com/apache/iceberg/pull/10848
>>>>
>>>> Thanks,
>>>>
>>>> Amogh Jahagirdar
>>>>
>>>
>
> --
> Ryan Blue
> Databricks
>
>

Re: [VOTE] Merge REST spec clarification on how servers should handle unknown updates/requirements

Posted by xianjin <xi...@apache.org>.
+1

  

> On Aug 14, 2024, at 2:24 AM, Ryan Blue <bl...@databricks.com.invalid> wrote:  
>  
>

> 
>
> +1  
>
>
>  
>
>
> On Tue, Aug 13, 2024 at 8:59 AM Yufei Gu
> <[flyrain000@gmail.com](mailto:flyrain000@gmail.com)> wrote:  
>
>

>> +1  
>
>>

>> Yufei

>>

>>  
>
>>

>>  
>
>>

>> On Tue, Aug 13, 2024 at 8:57 AM Eduard Tudenhöfner
<[etudenhoefner@apache.org](mailto:etudenhoefner@apache.org)> wrote:  
>
>>

>>> +1  
>
>>>

>>>  
>
>>>

>>> On Tue, Aug 13, 2024 at 5:09 PM Amogh Jahagirdar
<[2amogh@gmail.com](mailto:2amogh@gmail.com)> wrote:  
>
>>>

>>>> I've opened a PR [1] to clarify in the REST spec that if a server
receives an unknown update or requirement as part of any the commit endpoints,
that the server must fail with a 400 error response.  
>
>>>>

>>>>  
>
>>>>

>>>> Please vote on merging this change.  The vote will remain open for at
least 72 hours.

>>>>

>>>>  
>
>>>>

>>>> [] +1

>>>>

>>>> [] +0

>>>>

>>>> [] -1, do not merge because ...

>>>>

>>>>  
>
>>>>

>>>> [1] <https://github.com/apache/iceberg/pull/10848>  
>
>>>>

>>>>  
>
>>>>

>>>> Thanks,

>>>>

>>>>  
>
>>>>

>>>> Amogh Jahagirdar

>
>  
>
>
>  
>
>
> \--  
>
>
> Ryan Blue
>
> Databricks

Re: [VOTE] Merge REST spec clarification on how servers should handle unknown updates/requirements

Posted by Ryan Blue <bl...@databricks.com.INVALID>.
+1

On Tue, Aug 13, 2024 at 8:59 AM Yufei Gu <fl...@gmail.com> wrote:

> +1
> Yufei
>
>
> On Tue, Aug 13, 2024 at 8:57 AM Eduard Tudenhöfner <
> etudenhoefner@apache.org> wrote:
>
>> +1
>>
>> On Tue, Aug 13, 2024 at 5:09 PM Amogh Jahagirdar <2a...@gmail.com>
>> wrote:
>>
>>> I've opened a PR [1] to clarify in the REST spec that if a server
>>> receives an unknown update or requirement as part of any the commit
>>> endpoints, that the server must fail with a 400 error response.
>>>
>>> Please vote on merging this change.  The vote will remain open for at
>>> least 72 hours.
>>>
>>> [] +1
>>> [] +0
>>> [] -1, do not merge because ...
>>>
>>> [1] https://github.com/apache/iceberg/pull/10848
>>>
>>> Thanks,
>>>
>>> Amogh Jahagirdar
>>>
>>

-- 
Ryan Blue
Databricks

Re: [VOTE] Merge REST spec clarification on how servers should handle unknown updates/requirements

Posted by Yufei Gu <fl...@gmail.com>.
+1
Yufei


On Tue, Aug 13, 2024 at 8:57 AM Eduard Tudenhöfner <et...@apache.org>
wrote:

> +1
>
> On Tue, Aug 13, 2024 at 5:09 PM Amogh Jahagirdar <2a...@gmail.com> wrote:
>
>> I've opened a PR [1] to clarify in the REST spec that if a server
>> receives an unknown update or requirement as part of any the commit
>> endpoints, that the server must fail with a 400 error response.
>>
>> Please vote on merging this change.  The vote will remain open for at
>> least 72 hours.
>>
>> [] +1
>> [] +0
>> [] -1, do not merge because ...
>>
>> [1] https://github.com/apache/iceberg/pull/10848
>>
>> Thanks,
>>
>> Amogh Jahagirdar
>>
>

Re: [VOTE] Merge REST spec clarification on how servers should handle unknown updates/requirements

Posted by Eduard Tudenhöfner <et...@apache.org>.
+1

On Tue, Aug 13, 2024 at 5:09 PM Amogh Jahagirdar <2a...@gmail.com> wrote:

> I've opened a PR [1] to clarify in the REST spec that if a server
> receives an unknown update or requirement as part of any the commit
> endpoints, that the server must fail with a 400 error response.
>
> Please vote on merging this change.  The vote will remain open for at
> least 72 hours.
>
> [] +1
> [] +0
> [] -1, do not merge because ...
>
> [1] https://github.com/apache/iceberg/pull/10848
>
> Thanks,
>
> Amogh Jahagirdar
>