You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "scottyaslan (via GitHub)" <gi...@apache.org> on 2026/05/08 21:22:49 UTC

[PR] NIFI-15920 improve accesibility around connector state text in listing [nifi]

scottyaslan opened a new pull request, #11225:
URL: https://github.com/apache/nifi/pull/11225

   <!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
   <!-- contributor license agreements.  See the NOTICE file distributed with -->
   <!-- this work for additional information regarding copyright ownership. -->
   <!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
   <!-- (the "License"); you may not use this file except in compliance with -->
   <!-- the License.  You may obtain a copy of the License at -->
   <!--     http://www.apache.org/licenses/LICENSE-2.0 -->
   <!-- Unless required by applicable law or agreed to in writing, software -->
   <!-- distributed under the License is distributed on an "AS IS" BASIS, -->
   <!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
   <!-- See the License for the specific language governing permissions and -->
   <!-- limitations under the License. -->
   
   # Summary
   
   [NIFI-15920](https://issues.apache.org/jira/browse/NIFI-15920)
   
   Current main has some unreadable text:
   
   <img width="1425" height="1022" alt="Screenshot 2026-05-08 at 5 18 02 PM" src="https://github.com/user-attachments/assets/8612b9aa-2376-42bb-8ec8-2024ea32e7c6" />
   
   <img width="1426" height="1019" alt="Screenshot 2026-05-08 at 5 17 53 PM" src="https://github.com/user-attachments/assets/90e40c96-5e58-4069-bef5-37c6634aa2d0" />
   
   This PR utilized established pattern from nifi to mark the state of the connector as "edits not applied":
   
   <img width="1428" height="600" alt="Screenshot 2026-05-08 at 5 17 19 PM" src="https://github.com/user-attachments/assets/c5b75809-6d54-4cf7-ab23-02d46be8bfa0" />
   <img width="1428" height="1016" alt="Screenshot 2026-05-08 at 5 17 37 PM" src="https://github.com/user-attachments/assets/c80801e7-2bec-4fb6-9fbf-d24a5d1a0e01" />
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
   
   ### Pull Request Tracking
   
   - Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
   - Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
   - Pull request contains [commits signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) with a registered key indicating `Verified` status
   
   ### Pull Request Formatting
   
   - Pull Request based on current revision of the `main` branch
   - Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request creation.
   
   ### Build
   
   - [ ] Build completed using `./mvnw clean install -P contrib-check`
     - [ ] JDK 21
     - [ ] JDK 25
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] NIFI-15920 improve accesibility around connector state text in listing [nifi]

Posted by "scottyaslan (via GitHub)" <gi...@apache.org>.
scottyaslan commented on code in PR #11225:
URL: https://github.com/apache/nifi/pull/11225#discussion_r3230588780


##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/connectors/ui/connector-table/connector-table.component.html:
##########
@@ -76,9 +76,10 @@
                     <div class="inline-flex items-center gap-x-2">
                         <span [title]="formatState(item)">{{ formatState(item) }}</span>
                         @if (canRead(item) && canDiscardConfig(item)) {
-                            <span class="caution-color text-xs font-medium" data-qa="edits-not-applied-badge"
-                                >(Edits not applied)</span
-                            >
+                            <i
+                                class="neutral-color fa fa-asterisk"
+                                matTooltip="Edits not applied"
+                                matTooltipPosition="after"></i>

Review Comment:
   <img width="1426" height="937" alt="Screenshot 2026-05-12 at 8 09 15 PM" src="https://github.com/user-attachments/assets/2e2b05f0-311b-455c-8e42-2516a23370f0" />
   <img width="390" height="204" alt="Screenshot 2026-05-12 at 8 09 25 PM" src="https://github.com/user-attachments/assets/cb37d334-c6bb-4315-a7f1-830874e54be3" />
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] NIFI-15920 improve accesibility around connector state text in listing [nifi]

Posted by "mcgilman (via GitHub)" <gi...@apache.org>.
mcgilman commented on code in PR #11225:
URL: https://github.com/apache/nifi/pull/11225#discussion_r3236123627


##########
nifi-frontend/src/main/frontend/libs/shared/src/components/status-badge/status-badge.component.ts:
##########
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { Component, Input } from '@angular/core';
+import { StatusVariant } from '../../types';
+import { MatIcon } from '@angular/material/icon';
+import { MatTooltip } from '@angular/material/tooltip';
+
+@Component({
+    selector: 'status-badge',
+    imports: [MatIcon, MatTooltip],

Review Comment:
   `MatIcon` is unused.



##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/connectors/ui/connector-table/connector-table.component.ts:
##########
@@ -113,6 +124,26 @@ export class ConnectorTable {
         return getConnectorActionDisabledReason(entity, actionName);
     }
 
+    getStateVariant(entity: ConnectorEntity): StatusVariant {

Review Comment:
   This logic is duplicated. Please extract into a common util.



##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/connectors/ui/connector-table/connector-table.component.scss:
##########
@@ -14,13 +14,3 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-
-.connector-table {
-    .listing-table {
-        table {
-            .mat-column-moreDetails {
-                width: 74px;

Review Comment:
   Why was this removed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] NIFI-15920 improve accesibility around connector state text in listing [nifi]

Posted by "mcgilman (via GitHub)" <gi...@apache.org>.
mcgilman commented on PR #11225:
URL: https://github.com/apache/nifi/pull/11225#issuecomment-4420987824

   Reviewing...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] NIFI-15920 improve accesibility around connector state text in listing [nifi]

Posted by "scottyaslan (via GitHub)" <gi...@apache.org>.
scottyaslan commented on code in PR #11225:
URL: https://github.com/apache/nifi/pull/11225#discussion_r3230588780


##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/connectors/ui/connector-table/connector-table.component.html:
##########
@@ -76,9 +76,10 @@
                     <div class="inline-flex items-center gap-x-2">
                         <span [title]="formatState(item)">{{ formatState(item) }}</span>
                         @if (canRead(item) && canDiscardConfig(item)) {
-                            <span class="caution-color text-xs font-medium" data-qa="edits-not-applied-badge"
-                                >(Edits not applied)</span
-                            >
+                            <i
+                                class="neutral-color fa fa-asterisk"
+                                matTooltip="Edits not applied"
+                                matTooltipPosition="after"></i>

Review Comment:
   <img width="1426" height="937" alt="Screenshot 2026-05-12 at 8 09 15 PM" src="https://github.com/user-attachments/assets/2e2b05f0-311b-455c-8e42-2516a23370f0" />
   <img width="1426" height="937" alt="Screenshot 2026-05-12 at 8 09 15 PM" src="https://github.com/user-attachments/assets/2e2b05f0-311b-455c-8e42-2516a23370f0" />
   <img width="390" height="204" alt="Screenshot 2026-05-12 at 8 09 25 PM" src="https://github.com/user-attachments/assets/cb37d334-c6bb-4315-a7f1-830874e54be3" />
   <img width="390" height="204" alt="Screenshot 2026-05-12 at 8 09 25 PM" src="https://github.com/user-attachments/assets/cb37d334-c6bb-4315-a7f1-830874e54be3" />
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] NIFI-15920 improve accesibility around connector state text in listing [nifi]

Posted by "scottyaslan (via GitHub)" <gi...@apache.org>.
scottyaslan commented on code in PR #11225:
URL: https://github.com/apache/nifi/pull/11225#discussion_r3236921380


##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/connectors/ui/connector-table/connector-table.component.scss:
##########
@@ -14,13 +14,3 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-
-.connector-table {
-    .listing-table {
-        table {
-            .mat-column-moreDetails {
-                width: 74px;

Review Comment:
   That's my bad. I thought we had global styles for the moreDetails column. It is restored.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] NIFI-15920 improve accesibility around connector state text in listing [nifi]

Posted by "mcgilman (via GitHub)" <gi...@apache.org>.
mcgilman merged PR #11225:
URL: https://github.com/apache/nifi/pull/11225


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] NIFI-15920 improve accesibility around connector state text in listing [nifi]

Posted by "mcgilman (via GitHub)" <gi...@apache.org>.
mcgilman commented on code in PR #11225:
URL: https://github.com/apache/nifi/pull/11225#discussion_r3219356034


##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/connectors/ui/connector-table/connector-table.component.html:
##########
@@ -76,9 +76,10 @@
                     <div class="inline-flex items-center gap-x-2">
                         <span [title]="formatState(item)">{{ formatState(item) }}</span>
                         @if (canRead(item) && canDiscardConfig(item)) {
-                            <span class="caution-color text-xs font-medium" data-qa="edits-not-applied-badge"
-                                >(Edits not applied)</span
-                            >
+                            <i
+                                class="neutral-color fa fa-asterisk"
+                                matTooltip="Edits not applied"
+                                matTooltipPosition="after"></i>

Review Comment:
   Personally, I'm not a fan of this tooltip approach. 
   
   We already show `EDITS NOT APPLIED` in the Connector card in the Connector canvas. We probably need to align these. Assuming the Connector card also suffers with the yellow text on white surface maybe we can consider a little badge or something. 
   
   Thoughts?
   
   <img width="381" height="187" alt="Image" src="https://github.com/user-attachments/assets/a7f17764-4904-47b6-8934-48600c546848" />



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org