You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@solr.apache.org by "Noble Paul (Jira)" <ji...@apache.org> on 2023/05/04 07:53:00 UTC

[jira] [Commented] (SOLR-16507) Remove NodeStateProvider & Snitch

    [ https://issues.apache.org/jira/browse/SOLR-16507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17719193#comment-17719193 ] 

Noble Paul commented on SOLR-16507:
-----------------------------------

[~dsmiley] pls review the [PR|https://github.com/apache/solr/pull/1625] 

> Remove NodeStateProvider & Snitch
> ---------------------------------
>
>                 Key: SOLR-16507
>                 URL: https://issues.apache.org/jira/browse/SOLR-16507
>             Project: Solr
>          Issue Type: Task
>            Reporter: David Smiley
>            Assignee: Noble Paul
>            Priority: Major
>              Labels: newdev
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> The NodeStateProvider is a relic relating to the old autoscaling framework that was removed in Solr 9.  The only remaining usage of it is for SplitShardCmd to check the disk space.  For this, it could use the metrics api.
> I think we'll observe that Snitch and other classes in org.apache.solr.common.cloud.rule can be removed as well, as it's related to NodeStateProvider.
> Only org.apache.solr.cluster.placement.impl.AttributeFetcherImpl#getMetricSnitchTag and org.apache.solr.cluster.placement.impl.NodeMetricImpl refer to some constants in the code to be removed.  Those constants could move out, consolidated somewhere we think is appropriate.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org