You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2018/12/10 12:41:43 UTC
svn commit: r1848566 - in
/tomcat/trunk/java/org/apache/catalina/webresources: JarWarResourceSet.java
LocalStrings.properties
Author: markt
Date: Mon Dec 10 12:41:43 2018
New Revision: 1848566
URL: http://svn.apache.org/viewvc?rev=1848566&view=rev
Log:
Don't use an initial capital in the key name
Modified:
tomcat/trunk/java/org/apache/catalina/webresources/JarWarResourceSet.java
tomcat/trunk/java/org/apache/catalina/webresources/LocalStrings.properties
Modified: tomcat/trunk/java/org/apache/catalina/webresources/JarWarResourceSet.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/webresources/JarWarResourceSet.java?rev=1848566&r1=1848565&r2=1848566&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/webresources/JarWarResourceSet.java (original)
+++ tomcat/trunk/java/org/apache/catalina/webresources/JarWarResourceSet.java Mon Dec 10 12:41:43 2018
@@ -222,7 +222,7 @@ public class JarWarResourceSet extends A
*/
@Override
protected JarEntry getArchiveEntry(String pathInArchive) {
- throw new IllegalStateException(sm.getString("JarWarResourceSet.codingError"));
+ throw new IllegalStateException(sm.getString("jarWarResourceSet.codingError"));
}
Modified: tomcat/trunk/java/org/apache/catalina/webresources/LocalStrings.properties
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/webresources/LocalStrings.properties?rev=1848566&r1=1848565&r2=1848566&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/webresources/LocalStrings.properties [UTF-8] (original)
+++ tomcat/trunk/java/org/apache/catalina/webresources/LocalStrings.properties [UTF-8] Mon Dec 10 12:41:43 2018
@@ -45,7 +45,7 @@ jarResource.getUrlFail=Unable to determi
jarResourceRoot.invalidWebAppPath=This resource always refers to a directory so the supplied webAppPath must end with / but the provided webAppPath was [{0}]
-JarWarResourceSet.codingError=Coding error
+jarWarResourceSet.codingError=Coding error
standardRoot.checkStateNotStarted=The resources may not be accessed if they are not currently started
standardRoot.createInvalidFile=Unable to create WebResourceSet from [{0}]
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1848566 - in
/tomcat/trunk/java/org/apache/catalina/webresources: JarWarResourceSet.java
LocalStrings.properties
Posted by Mark Thomas <ma...@apache.org>.
On 10/12/2018 12:55, Rémy Maucherat wrote:
> On Mon, Dec 10, 2018 at 1:41 PM <ma...@apache.org> wrote:
>
>> Author: markt
>> Date: Mon Dec 10 12:41:43 2018
>> New Revision: 1848566
>>
>> URL: http://svn.apache.org/viewvc?rev=1848566&view=rev
>> Log:
>> Don't use an initial capital in the key name
>>
>
> Sorry for all the mistakes, I had tried to be creaful. About this one, I
> wonder why this rule exists in the first place though, it corresponds to a
> class name and there's not posible confusion.
Don't worry about it. Not a big deal. Most of these have been present
for a while. I should have caught them when I did the clean-up before
the initial import to POEditor but I missed them.
I'm not sure why the name format is what it is. Before my time I
suspect. It is used consistently enough that I thought it was worth keeping.
I take the point about class names. I don't think making the switch is
worth it at this point though.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1848566 - in /tomcat/trunk/java/org/apache/catalina/webresources:
JarWarResourceSet.java LocalStrings.properties
Posted by Rémy Maucherat <re...@apache.org>.
On Mon, Dec 10, 2018 at 1:41 PM <ma...@apache.org> wrote:
> Author: markt
> Date: Mon Dec 10 12:41:43 2018
> New Revision: 1848566
>
> URL: http://svn.apache.org/viewvc?rev=1848566&view=rev
> Log:
> Don't use an initial capital in the key name
>
Sorry for all the mistakes, I had tried to be creaful. About this one, I
wonder why this rule exists in the first place though, it corresponds to a
class name and there's not posible confusion.
Rémy