You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2018/09/01 04:27:37 UTC
Review Request 68597: Made copy backend destroy more robust.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68597/
-----------------------------------------------------------
Review request for mesos, Chun-Hung Hsiao and Gilbert Song.
Bugs: MESOS-9196
https://issues.apache.org/jira/browse/MESOS-9196
Repository: mesos
Description
-------
Do not return hard failure if `rm -rf` failed. It's also possible that
it fails if some other processes are accessing the files there. The
cleanup will be re-attempted during provisioner destroy and agent
recovery.
Diffs
-----
src/slave/containerizer/mesos/provisioner/backends/copy.cpp d3eb6b443d49e1cd6cfd7fa3be1776155e8a1bb0
Diff: https://reviews.apache.org/r/68597/diff/1/
Testing
-------
sudo make check
Thanks,
Jie Yu
Re: Review Request 68597: Made copy backend destroy more robust.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68597/#review208218
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On Aug. 31, 2018, 9:50 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68597/
> -----------------------------------------------------------
>
> (Updated Aug. 31, 2018, 9:50 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Gilbert Song.
>
>
> Bugs: MESOS-9196
> https://issues.apache.org/jira/browse/MESOS-9196
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Do not return hard failure if `rm -rf` failed. It's also possible that
> it fails if some other processes are accessing the files there. The
> cleanup will be re-attempted during provisioner destroy and agent
> recovery.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/backends/copy.cpp d3eb6b443d49e1cd6cfd7fa3be1776155e8a1bb0
>
>
> Diff: https://reviews.apache.org/r/68597/diff/2/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 68597: Made copy backend destroy more robust.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68597/#review208220
-----------------------------------------------------------
PASS: Mesos patch 68597 was successfully built and tested.
Reviews applied: `['68594', '68595', '68596', '68597']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2272/mesos-review-68597
- Mesos Reviewbot Windows
On Aug. 31, 2018, 9:50 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68597/
> -----------------------------------------------------------
>
> (Updated Aug. 31, 2018, 9:50 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Gilbert Song.
>
>
> Bugs: MESOS-9196
> https://issues.apache.org/jira/browse/MESOS-9196
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Do not return hard failure if `rm -rf` failed. It's also possible that
> it fails if some other processes are accessing the files there. The
> cleanup will be re-attempted during provisioner destroy and agent
> recovery.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/backends/copy.cpp d3eb6b443d49e1cd6cfd7fa3be1776155e8a1bb0
>
>
> Diff: https://reviews.apache.org/r/68597/diff/2/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 68597: Made copy backend destroy more robust.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68597/
-----------------------------------------------------------
(Updated Sept. 1, 2018, 4:50 a.m.)
Review request for mesos, Chun-Hung Hsiao and Gilbert Song.
Changes
-------
Fixed typos.
Bugs: MESOS-9196
https://issues.apache.org/jira/browse/MESOS-9196
Repository: mesos
Description
-------
Do not return hard failure if `rm -rf` failed. It's also possible that
it fails if some other processes are accessing the files there. The
cleanup will be re-attempted during provisioner destroy and agent
recovery.
Diffs (updated)
-----
src/slave/containerizer/mesos/provisioner/backends/copy.cpp d3eb6b443d49e1cd6cfd7fa3be1776155e8a1bb0
Diff: https://reviews.apache.org/r/68597/diff/2/
Changes: https://reviews.apache.org/r/68597/diff/1-2/
Testing
-------
sudo make check
Thanks,
Jie Yu