You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/08/14 20:43:35 UTC
[GitHub] [cloudstack] ggoodrich-ipp opened a new pull request #4266: Adding os type id to the usage record response for virtual machines
ggoodrich-ipp opened a new pull request #4266:
URL: https://github.com/apache/cloudstack/pull/4266
## Description
<!--- Describe your changes in detail -->
Adding the Os Type Id to the CloudStack Api response for listUsageRecords for running and allocated VMs. When attempting to determine what type of VM was being used for a removed VM, the listVirtualMachines Api will not return a result, as the record has been marked removed. For our purposes, the type of OS is still required for usage purposes. This change simply adds that additional element to the output.
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
I have been leveraging the Api for retrieving usage information for virtual machines of specific types fairly extensively.
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
This change simply adds an additional element to the output, and thus should be considered a non-breaking change.
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4266: Adding os type id to the usage record response for virtual machines
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4266:
URL: https://github.com/apache/cloudstack/pull/4266#issuecomment-679804319
@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ggoodrich-ipp commented on a change in pull request #4266: Adding os type id to the usage record response for virtual machines
Posted by GitBox <gi...@apache.org>.
ggoodrich-ipp commented on a change in pull request #4266:
URL: https://github.com/apache/cloudstack/pull/4266#discussion_r588354445
##########
File path: server/src/main/java/com/cloud/api/ApiResponseHelper.java
##########
@@ -3386,6 +3386,7 @@ public UsageRecordResponse createUsageResponse(Usage usageRecord, Map<String, Se
resourceType = ResourceTag.ResourceObjectType.UserVm;
usageRecResponse.setUsageId(vm.getUuid());
resourceId = vm.getId();
+ usageRecResponse.setOsTypeId(vm.getGuestOSId());
Review comment:
I guess I must've realized this, as I'm storing this off as an int in a local billing database. Is it an easy fix to change this to get the UUID? It appears where I'm using it, I fetch this int value, and then use it to go get the UUID, so it seems the UUID is ultimately what I need. Maybe I used the int as that was already in the model? It has been far enough back that I don't recall the specifics.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4266: Adding os type id to the usage record response for virtual machines
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4266:
URL: https://github.com/apache/cloudstack/pull/4266#discussion_r588029903
##########
File path: server/src/main/java/com/cloud/api/ApiResponseHelper.java
##########
@@ -3386,6 +3386,7 @@ public UsageRecordResponse createUsageResponse(Usage usageRecord, Map<String, Se
resourceType = ResourceTag.ResourceObjectType.UserVm;
usageRecResponse.setUsageId(vm.getUuid());
resourceId = vm.getId();
+ usageRecResponse.setOsTypeId(vm.getGuestOSId());
Review comment:
@ggoodrich-ipp we just caught that this sets the DB internal ID and not UUID, should we fix that in 4.15.1?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4266: Adding os type id to the usage record response for virtual machines
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4266:
URL: https://github.com/apache/cloudstack/pull/4266#issuecomment-679802610
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4266: Adding os type id to the usage record response for virtual machines
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4266:
URL: https://github.com/apache/cloudstack/pull/4266
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4266: Adding os type id to the usage record response for virtual machines
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4266:
URL: https://github.com/apache/cloudstack/pull/4266#issuecomment-679834909
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-1815
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4266: Adding os type id to the usage record response for virtual machines
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4266:
URL: https://github.com/apache/cloudstack/pull/4266#issuecomment-679966394
Simple API setter fix, merging based on Travis tests and packaging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org