You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2013/06/26 23:47:52 UTC
[Bug 122600] New: [SVG] problems in SvgSvgNode
https://issues.apache.org/ooo/show_bug.cgi?id=122600
Bug ID: 122600
Issue Type: TASK
Summary: [SVG] problems in SvgSvgNode
Product: Draw
Version: AOO400-dev
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: code
Assignee: issues@openoffice.apache.org
Reporter: rb.henschel@t-online.de
CC: Armin.Le.Grand@me.com, issues@openoffice.apache.org
Blocks: 122575, 122593, 122594, 122599
I have generated this TASK issue to collect all the problems with SvgSvgNode.
These have likely to be solved all together, but it is better for testing the
solution, when each problem has it's own description.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 122600] [SVG] problems in SvgSvgNode
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122600
--- Comment #7 from SVN Robot <sv...@dev.null.org> ---
"alg" committed SVN revision 1513592 into branches/AOO401:
i122600 Added patch from Regina that fixes a bunch of tasks (list see in
task...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Bug 122600] [SVG] problems in SvgSvgNode
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122600
Regina Henschel <rb...@t-online.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |122610
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
[Bug 122600] [SVG] problems in SvgSvgNode
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122600
--- Comment #23 from Regina Henschel <rb...@t-online.de> ---
Verified all depending issues and set them to fixed.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Issue 122600] [SVG] problems in SvgSvgNode
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122600
Regina Henschel <rb...@t-online.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |CLOSED
--- Comment #28 from Regina Henschel <rb...@t-online.de> ---
All sub-issues solved. Close the task.
--
You are receiving this mail because:
You are on the CC list for the issue.
You are watching all issue changes.
[Bug 122600] [SVG] problems in SvgSvgNode
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122600
Armin Le Grand <Ar...@me.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Version|4.0.0-dev |4.0.1-dev
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Bug 122600] [SVG] problems in SvgSvgNode
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122600
Armin Le Grand <Ar...@me.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ACCEPTED |RESOLVED
Resolution|--- |FIXED
--- Comment #8 from Armin Le Grand <Ar...@me.com> ---
ALG: Comitted in trunk and AOO401 branch, done.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Bug 122600] [SVG] problems in SvgSvgNode
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122600
--- Comment #24 from Oliver-Rainer Wittmann <or...@apache.org> ---
(In reply to Regina Henschel from comment #23)
> Verified all depending issues and set them to fixed.
Cool. Thank you
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Bug 122600] [SVG] problems in SvgSvgNode
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122600
Oliver-Rainer Wittmann <or...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|FIXED |---
--- Comment #14 from Oliver-Rainer Wittmann <or...@apache.org> ---
(In reply to Regina Henschel from comment #13)
> (In reply to Oliver-Rainer Wittmann from comment #12)
> >
> > [snip]
> >
>
> I can apply your patch.
> I have tested my test cases with primitives like rectangle, circle and
> ellipse. That cases pass all well. Need to look at markers now, but that
> needs some time.
sounds good.
If all your test cases pass well, I think we should consult apply the patch in
order to get a Linux 32bit build bot build. But we should leave this issue open
in order to get a review from Armin.
Again ;-) - changing status to REOPENED
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Bug 122600] [SVG] problems in SvgSvgNode
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122600
Oliver-Rainer Wittmann <or...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #81333| |review?
Flags| |
--- Comment #9 from Oliver-Rainer Wittmann <or...@apache.org> ---
Created attachment 81333
--> https://issues.apache.org/ooo/attachment.cgi?id=81333&action=edit
patch to solve build breaker on Linux 32bit build bot
adjustment to correct compile error on Linux 32bit build bot.
the compile error is:
/home/buildslave20/slave20/openoffice-linux32-nightly/build/main/svgio/source/svgreader/svgsvgnode.cxx:
In member function 'virtual const basegfx::B2DRange*
svgio::svgreader::SvgSvgNode::getCurrentViewPort() const':
/home/buildslave20/slave20/openoffice-linux32-nightly/build/main/svgio/source/svgreader/svgsvgnode.cxx:636:71:
error: taking address of temporary [-fpermissive]
/home/buildslave20/slave20/openoffice-linux32-nightly/build/main/svgio/source/svgreader/svgsvgnode.cxx:679:75:
error: taking address of temporary [-fpermissive]
/home/buildslave20/slave20/openoffice-linux32-nightly/build/main/svgio/source/svgreader/svgsvgnode.cxx:698:67:
error: taking address of temporary [-fpermissive]
make: ***
[/home/buildslave20/slave20/openoffice-linux32-nightly/build/main/solver/400/unxlngi6.pro/workdir/CxxObject/svgio/source/svgreader/svgsvgnode.o]
Error 1
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Bug 122600] [SVG] problems in SvgSvgNode
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122600
Oliver-Rainer Wittmann <or...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
CC| |orw@apache.org
Resolution|FIXED |---
--- Comment #12 from Oliver-Rainer Wittmann <or...@apache.org> ---
(In reply to Regina Henschel from comment #11)
> I get in apply
> warning: main/svgio/source/svgreader/svgsvgnode.cxx has type 100755,
> expected 100644
hm... I am not sure.
I assume that you applied the patch which I attached. Right?
It looks like as the access rights to the file are not the ones which the
'patch' tool is expecting.
BTW, I am changing the issue status back to REOPENED as I think we need to
solve the compile error on Linux 32bit build bot. I could the same compile
error on my Ubuntu 11.10 32bit VM.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Bug 122600] [SVG] problems in SvgSvgNode
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122600
--- Comment #20 from SVN Robot <sv...@dev.null.org> ---
"alg" committed SVN revision 1517538 into branches/AOO401:
122600: solve access memory problem of <SvgSvgNode::getCurrentViewPort()>
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
review requested: [Bug 122600] [SVG] problems in SvgSvgNode :
[Attachment 81251] Updated patch
Posted by bu...@apache.org.
Regina Henschel <rb...@t-online.de> has asked Armin Le Grand
<Ar...@me.com> for review:
Bug 122600: [SVG] problems in SvgSvgNode
https://issues.apache.org/ooo/show_bug.cgi?id=122600
Attachment 81251: Updated patch
https://issues.apache.org/ooo/attachment.cgi?id=81251&action=edit
[Bug 122600] [SVG] problems in SvgSvgNode
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122600
Regina Henschel <rb...@t-online.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution|--- |FIXED
--- Comment #13 from Regina Henschel <rb...@t-online.de> ---
(In reply to Oliver-Rainer Wittmann from comment #12)
> hm... I am not sure.
>
> I assume that you applied the patch which I attached. Right?
Yes. I use "git apply".
> It looks like as the access rights to the file are not the ones which the
> 'patch' tool is expecting.
>
>
> BTW, I am changing the issue status back to REOPENED as I think we need to
> solve the compile error on Linux 32bit build bot. I could the same compile
> error on my Ubuntu 11.10 32bit VM.
That is OK.
I can apply your patch.
I have tested my test cases with primitives like rectangle, circle and ellipse.
That cases pass all well. Need to look at markers now, but that needs some
time.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Bug 122600] [SVG] problems in SvgSvgNode
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122600
--- Comment #6 from SVN Robot <sv...@dev.null.org> ---
"alg" committed SVN revision 1513591 into trunk:
i122600 Added patch from Regina that fixes a bunch of tasks (list see in
task...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Bug 122600] [SVG] problems in SvgSvgNode
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122600
Regina Henschel <rb...@t-online.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #81251| |review?(Armin.Le.Grand@me.c
Flags| |om)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Bug 122600] [SVG] problems in SvgSvgNode
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122600
Oliver-Rainer Wittmann <or...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|FIXED |---
--- Comment #10 from Oliver-Rainer Wittmann <or...@apache.org> ---
reopened for adjusting the patched code
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Bug 122600] [SVG] problems in SvgSvgNode
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122600
--- Comment #16 from Oliver-Rainer Wittmann <or...@apache.org> ---
(In reply to Oliver-Rainer Wittmann from comment #14)
> (In reply to Regina Henschel from comment #13)
> > (In reply to Oliver-Rainer Wittmann from comment #12)
> > >
> > > [snip]
> > >
> >
> > I can apply your patch.
> > I have tested my test cases with primitives like rectangle, circle and
> > ellipse. That cases pass all well. Need to look at markers now, but that
> > needs some time.
>
> sounds good.
> If all your test cases pass well, I think we should apply the patch
> in order to get a Linux 32bit build bot build. But we should leave this
> issue open in order to get a review from Armin.
>
Private communication with Regina reveals that all test cases went well.
Thus, I will apply the patch on trunk, but not yet on branch AOO401.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Bug 122600] [SVG] problems in SvgSvgNode
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122600
Regina Henschel <rb...@t-online.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |122919
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Bug 122600] [SVG] problems in SvgSvgNode
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122600
Regina Henschel <rb...@t-online.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #81247| |review?(Armin.Le.Grand@me.c
Flags| |om)
Status|UNCONFIRMED |ACCEPTED
Assignee|issues@openoffice.apache.or |rb.henschel@t-online.de
|g |
Ever confirmed|0 |1
--- Comment #1 from Regina Henschel <rb...@t-online.de> ---
Created attachment 81247
--> https://issues.apache.org/ooo/attachment.cgi?id=81247&action=edit
Patch to solve several errors with svgsvgnode
The patch assumes, that the internal mpViewBox has the parameter meaning
x1,y1,x2,y2 and therefore converts the svg meaning x,y,width,height
accordingly.
The patch effects only svgio.
The patch corrects several bugs and shortcomings in svgsvgnode. Find some test
documents in the linked issues.
The patch corrects in addition the wrong number type of radius for circle and
ellipse.
The patch is large. I suggest to discuss any questions and remarks on the
dev-mailing list.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
review requested: [Bug 122600] [SVG] problems in SvgSvgNode :
[Attachment 81333] patch to solve build breaker on Linux 32bit build bot
Posted by bu...@apache.org.
Oliver-Rainer Wittmann <or...@apache.org> has asked for review:
Bug 122600: [SVG] problems in SvgSvgNode
https://issues.apache.org/ooo/show_bug.cgi?id=122600
Attachment 81333: patch to solve build breaker on Linux 32bit build bot
https://issues.apache.org/ooo/attachment.cgi?id=81333&action=edit
------- Additional Comments from Oliver-Rainer Wittmann <or...@apache.org>
adjustment to correct compile error on Linux 32bit build bot.
the compile error is:
/home/buildslave20/slave20/openoffice-linux32-nightly/build/main/svgio/source/s
vgreader/svgsvgnode.cxx: In member function 'virtual const basegfx::B2DRange*
svgio::svgreader::SvgSvgNode::getCurrentViewPort() const':
/home/buildslave20/slave20/openoffice-linux32-nightly/build/main/svgio/source/s
vgreader/svgsvgnode.cxx:636:71: error: taking address of temporary
[-fpermissive]
/home/buildslave20/slave20/openoffice-linux32-nightly/build/main/svgio/source/s
vgreader/svgsvgnode.cxx:679:75: error: taking address of temporary
[-fpermissive]
/home/buildslave20/slave20/openoffice-linux32-nightly/build/main/svgio/source/s
vgreader/svgsvgnode.cxx:698:67: error: taking address of temporary
[-fpermissive]
make: ***
[/home/buildslave20/slave20/openoffice-linux32-nightly/build/main/solver/400/un
xlngi6.pro/workdir/CxxObject/svgio/source/svgreader/svgsvgnode.o] Error 1
[Bug 122600] [SVG] problems in SvgSvgNode
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122600
Regina Henschel <rb...@t-online.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |122912
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 122600] [SVG] problems in SvgSvgNode
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122600
--- Comment #22 from Oliver-Rainer Wittmann <or...@apache.org> ---
@Regina:
After Armin's review we have got this issue solved on trunk and on branch
AOO401.
Could you know check the depending issues and update their status accordingly?
Thx in advance.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Bug 122600] [SVG] problems in SvgSvgNode
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122600
Regina Henschel <rb...@t-online.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution|--- |FIXED
--- Comment #11 from Regina Henschel <rb...@t-online.de> ---
I get in apply
warning: main/svgio/source/svgreader/svgsvgnode.cxx has type 100755, expected
100644
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Bug 122600] [SVG] problems in SvgSvgNode
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122600
Regina Henschel <rb...@t-online.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|122575 |
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Bug 122600] [SVG] problems in SvgSvgNode
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122600
Kay <ks...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kschenk@apache.org
--- Comment #26 from Kay <ks...@apache.org> ---
I can import svg files OK on their own into a text document. I absolutely
positively can not import svg files into a frame in a text document. Plain
images into a frame are fine. I get error beeps then nothing. I don't know if
this is specifically related to this issue. I will search for one better
related to frames and svg specifically.
AOO401m4(Build:9713) - Rev. 1521921
2013-09-12 07:44 - Linux i686
Leaving as resolved -- probably more related to frames handling import.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Bug 122600] [SVG] problems in SvgSvgNode
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122600
Regina Henschel <rb...@t-online.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |122926
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 122600] [SVG] problems in SvgSvgNode
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122600
Armin Le Grand <Ar...@me.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |4.0.1_release_blocker?
--- Comment #4 from Armin Le Grand <Ar...@me.com> ---
ALG: Checked, only #122575# is not yet solved and needs to betaken out in my
opinion. All other stuff works well, compared with firefox as reference.
Well done, Regina!
Esp. using seekReferenceWidth/seekReferenceHeight is pretty much exactly what I
would have done, too ;-}
Also checked with all my collected svg bugdocs over time, all work well, no
regression visible.
Since this fixes a crash and a regression in AOO400 i request the showstopper
flag.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Bug 122600] [SVG] problems in SvgSvgNode
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122600
Armin Le Grand <Ar...@me.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution|--- |FIXED
--- Comment #19 from Armin Le Grand <Ar...@me.com> ---
ALG: Checked the patch, looks good. The key is anyways to ask for *.isEmpty at
the places where a comparison to NULL was used before. Sorry for having this
overlooked, and *argh* for the win compiler not asserting this. Is there a
compiler option for the win compiler to do so? If someone knows - this may be
worth turning it on, it is hunted by the linux version anyways.
Patch can be applied to OOO401 branch, too.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Bug 122600] [SVG] problems in SvgSvgNode
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122600
--- Comment #17 from SVN Robot <sv...@dev.null.org> ---
"orw" committed SVN revision 1516122 into trunk:
122600: solve access memory problem of <SvgSvgNode::getCurrentViewPort()>
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Bug 122600] [SVG] problems in SvgSvgNode
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122600
jsc@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jsc@apache.org
Issue Type|TASK |DEFECT
Flags|4.0.1_release_blocker? |4.0.1_release_blocker+
--- Comment #5 from jsc@apache.org ---
approve showstopper request
change type to defect because it solves primary a crash
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
review requested: [Bug 122600] [SVG] problems in SvgSvgNode :
[Attachment 81247] Patch to solve several errors with svgsvgnode
Posted by bu...@apache.org.
Regina Henschel <rb...@t-online.de> has asked Armin Le Grand
<Ar...@me.com> for review:
Bug 122600: [SVG] problems in SvgSvgNode
https://issues.apache.org/ooo/show_bug.cgi?id=122600
Attachment 81247: Patch to solve several errors with svgsvgnode
https://issues.apache.org/ooo/attachment.cgi?id=81247&action=edit
------- Additional Comments from Regina Henschel <rb...@t-online.de>
The patch assumes, that the internal mpViewBox has the parameter meaning
x1,y1,x2,y2 and therefore converts the svg meaning x,y,width,height
accordingly.
The patch effects only svgio.
The patch corrects several bugs and shortcomings in svgsvgnode. Find some test
documents in the linked issues.
The patch corrects in addition the wrong number type of radius for circle and
ellipse.
The patch is large. I suggest to discuss any questions and remarks on the
dev-mailing list.
[Bug 122600] [SVG] problems in SvgSvgNode
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122600
Regina Henschel <rb...@t-online.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |121453
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Bug 122600] [SVG] problems in SvgSvgNode
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122600
Oliver-Rainer Wittmann <or...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|rb.henschel@t-online.de |Armin.Le.Grand@me.com
--- Comment #18 from Oliver-Rainer Wittmann <or...@apache.org> ---
Armin:
As one of the experts in this area, could you please have a review of the
recently applied patch on trunk?
This patch respectively a revised one should be also applied on branch AOO401.
But before a review from your side is much appreciated. Thx in advance.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Bug 122600] [SVG] problems in SvgSvgNode
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122600
--- Comment #2 from Regina Henschel <rb...@t-online.de> ---
Change on svgellipsenode is wrong, have to reset that, but fix for
svgcirclenode is ok.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Bug 122600] [SVG] problems in SvgSvgNode
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122600
--- Comment #21 from Armin Le Grand <Ar...@me.com> ---
ALG: Comitted to AOO401 branch, too.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
4.0.1_release_blocker requested: [Bug 122600] [SVG] problems in
SvgSvgNode
Posted by bu...@apache.org.
Armin Le Grand <Ar...@me.com> has asked for 4.0.1_release_blocker:
Bug 122600: [SVG] problems in SvgSvgNode
https://issues.apache.org/ooo/show_bug.cgi?id=122600
------- Additional Comments from Armin Le Grand <Ar...@me.com>
ALG: Checked, only #122575# is not yet solved and needs to betaken out in my
opinion. All other stuff works well, compared with firefox as reference.
Well done, Regina!
Esp. using seekReferenceWidth/seekReferenceHeight is pretty much exactly what I
would have done, too ;-}
Also checked with all my collected svg bugdocs over time, all work well, no
regression visible.
Since this fixes a crash and a regression in AOO400 i request the showstopper
flag.
review canceled: [Bug 122600] [SVG] problems in SvgSvgNode :
[Attachment 81247] Patch to solve several errors with svgsvgnode
Posted by bu...@apache.org.
Regina Henschel <rb...@t-online.de> has canceled Regina Henschel
<rb...@t-online.de>'s request for review:
Bug 122600: [SVG] problems in SvgSvgNode
https://issues.apache.org/ooo/show_bug.cgi?id=122600
Attachment 81247: Patch to solve several errors with svgsvgnode
https://issues.apache.org/ooo/attachment.cgi?id=81247&action=edit
[Bug 122600] [SVG] problems in SvgSvgNode
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122600
jsc@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |4.0.1
--- Comment #25 from jsc@apache.org ---
set target milestone
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Bug 122600] [SVG] problems in SvgSvgNode
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122600
Regina Henschel <rb...@t-online.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #81247|0 |1
is obsolete| |
Attachment #81247|review?(Armin.Le.Grand@me.c |
Flags|om) |
--- Comment #3 from Regina Henschel <rb...@t-online.de> ---
Created attachment 81251
--> https://issues.apache.org/ooo/attachment.cgi?id=81251&action=edit
Updated patch
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
[Bug 122600] [SVG] problems in SvgSvgNode
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122600
--- Comment #27 from Armin Le Grand <Ar...@me.com> ---
ALG: @Kay: Thanks for checking.
- Is it possible in AOO341 to 'import svg files into a frame in a text
document'? If yes, how exactly to do that (in a new task).
- The beeps should be assertions for unknown SVG tags, a hint that the SVG is
interpreted at least...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
4.0.1_release_blocker granted: [Bug 122600] [SVG] problems in
SvgSvgNode
Posted by bu...@apache.org.
jsc@apache.org has granted Armin Le Grand <Ar...@me.com>'s request for
4.0.1_release_blocker:
Bug 122600: [SVG] problems in SvgSvgNode
https://issues.apache.org/ooo/show_bug.cgi?id=122600
------- Additional Comments from jsc@apache.org
approve showstopper request
change type to defect because it solves primary a crash
[Bug 122600] [SVG] problems in SvgSvgNode
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122600
--- Comment #15 from Oliver-Rainer Wittmann <or...@apache.org> ---
(In reply to Oliver-Rainer Wittmann from comment #14)
> (In reply to Regina Henschel from comment #13)
> > (In reply to Oliver-Rainer Wittmann from comment #12)
> > >
> > > [snip]
> > >
> >
> > I can apply your patch.
> > I have tested my test cases with primitives like rectangle, circle and
> > ellipse. That cases pass all well. Need to look at markers now, but that
> > needs some time.
>
> sounds good.
> If all your test cases pass well, I think we should consult apply the patch
> in order to get a Linux 32bit build bot build. But we should leave this
> issue open in order to get a review from Armin.
>
ignore word 'consult' - next time I will read my written text twice.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.