You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2019/03/08 14:22:02 UTC
Review Request 70166: Added test
`VolumeGidManagerTest.ROOT_UNPRIVILEGED_USER_SlaveReboot`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70166/
-----------------------------------------------------------
Review request for mesos, Andrei Budnik and Gilbert Song.
Bugs: MESOS-8767
https://issues.apache.org/jira/browse/MESOS-8767
Repository: mesos
Description
-------
This patch also moves `volume_gid_manager_tests.cpp` to `src/tests`.
Diffs
-----
src/Makefile.am aa9fd73169a95e94c6842b4da09279d3157c8f0e
src/tests/CMakeLists.txt 807ed1c7ee1c7d5582b8aa2e7d0f9e582f47fc49
src/tests/containerizer/volume_gid_manager_tests.cpp 6fc320557fb4bcabbf4210d7694894e5cbf0775c
Diff: https://reviews.apache.org/r/70166/diff/1/
Testing
-------
sudo make check
Thanks,
Qian Zhang
Re: Review Request 70166: Added test
`VolumeGidManagerTest.ROOT_UNPRIVILEGED_USER_SlaveReboot`.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70166/#review213571
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On March 8, 2019, 6:22 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70166/
> -----------------------------------------------------------
>
> (Updated March 8, 2019, 6:22 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Gilbert Song.
>
>
> Bugs: MESOS-8767
> https://issues.apache.org/jira/browse/MESOS-8767
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch also moves `volume_gid_manager_tests.cpp` to `src/tests`.
>
>
> Diffs
> -----
>
> src/Makefile.am aa9fd73169a95e94c6842b4da09279d3157c8f0e
> src/tests/CMakeLists.txt 807ed1c7ee1c7d5582b8aa2e7d0f9e582f47fc49
> src/tests/containerizer/volume_gid_manager_tests.cpp 6fc320557fb4bcabbf4210d7694894e5cbf0775c
>
>
> Diff: https://reviews.apache.org/r/70166/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 70166: Added test
`VolumeGidManagerTest.ROOT_UNPRIVILEGED_USER_SlaveReboot`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70166/#review213563
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70166]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 8, 2019, 2:22 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70166/
> -----------------------------------------------------------
>
> (Updated March 8, 2019, 2:22 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Gilbert Song.
>
>
> Bugs: MESOS-8767
> https://issues.apache.org/jira/browse/MESOS-8767
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch also moves `volume_gid_manager_tests.cpp` to `src/tests`.
>
>
> Diffs
> -----
>
> src/Makefile.am aa9fd73169a95e94c6842b4da09279d3157c8f0e
> src/tests/CMakeLists.txt 807ed1c7ee1c7d5582b8aa2e7d0f9e582f47fc49
> src/tests/containerizer/volume_gid_manager_tests.cpp 6fc320557fb4bcabbf4210d7694894e5cbf0775c
>
>
> Diff: https://reviews.apache.org/r/70166/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>