You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/07/13 09:09:37 UTC
[GitHub] [dolphinscheduler] Tandoy opened a new issue, #10936: [Bug] [task-plugin] There is an error in the logic of judge depend item finished in the dependent node
Tandoy opened a new issue, #10936:
URL: https://github.com/apache/dolphinscheduler/issues/10936
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
1.a workflow exists manual run and schedule run
2.the scheduled execution end time is later than the manual execution time
3.dependent node detection failed
### What you expected to happen
dependent node detection success
### How to reproduce
I found that the dependent node adopts the end time of process instance when taking the last process instance. Shouldn't it be the start time of the process instance?
[https://github.com/apache/dolphinscheduler/blob/dev/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/utils/DependentExecute.java](url)
### Anything else
If this is a bug, I will try to fix it.
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on issue #10936: [Bug] [task-plugin] There is an error in the logic of judge depend item finished in the dependent node
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on issue #10936:
URL: https://github.com/apache/dolphinscheduler/issues/10936#issuecomment-1185084785
I think use startTime or endTime is ok, since manual is only executed when schedule error or long time running. If schedule one is running for a long time, it will usually be killed first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Tandoy commented on issue #10936: [Bug] [task-plugin] There is an error in the logic of judge depend item finished in the dependent node
Posted by GitBox <gi...@apache.org>.
Tandoy commented on issue #10936:
URL: https://github.com/apache/dolphinscheduler/issues/10936#issuecomment-1185091268
> I think use startTime or endTime is ok, since manual is only executed when schedule error or long time running. If schedule one is running for a long time, it will usually be killed first.
yes,manual is only executed when schedule error or long time running.However, the scheduled execution end time may be later than the manual execution time due to resources or network reasons.In this case, if we use the end time to judge, we will not get the latest process instance status.As I described in what happened.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Tandoy commented on issue #10936: [Bug] [task-plugin] There is an error in the logic of judge depend item finished in the dependent node
Posted by GitBox <gi...@apache.org>.
Tandoy commented on issue #10936:
URL: https://github.com/apache/dolphinscheduler/issues/10936#issuecomment-1183022251
> Please describe your problem clearly, and AFAIK, we use endTime in dependent node to judge if the dependent node finished is our expected. cc @caishunfeng
IMO If there are multiple run records in the workflow, it should not be through the start time to obtain the last and latest workflow instance. As I described in what happened. cc @caishunfeng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #10936: [Bug] [task-plugin] There is an error in the logic of judge depend item finished in the dependent node
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #10936:
URL: https://github.com/apache/dolphinscheduler/issues/10936#issuecomment-1183008354
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
1.a workflow exists manual run and schedule run
2.the scheduled execution end time is later than the manual execution time
3.dependent node detection failed
### What you expected to happen
dependent node detection success
### How to reproduce
I found that the dependent node adopts the end time of process instance when taking the last process instance. Shouldn't it be the start time of the process instance?
[https://github.com/apache/dolphinscheduler/blob/dev/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/utils/DependentExecute.java](url)
### Anything else
If this is a bug, I will try to fix it.
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #10936: [Bug] [task-plugin] There is an error in the logic of judge depend item finished in the dependent node
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #10936:
URL: https://github.com/apache/dolphinscheduler/issues/10936#issuecomment-1183008626
Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can [join our slack](https://s.apache.org/dolphinscheduler-slack) and send your question to channel `#troubleshooting`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] closed issue #10936: [Bug] [task-plugin] There is an error in the logic of judge depend item finished in the dependent node
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed issue #10936: [Bug] [task-plugin] There is an error in the logic of judge depend item finished in the dependent node
URL: https://github.com/apache/dolphinscheduler/issues/10936
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun commented on issue #10936: [Bug] [task-plugin] There is an error in the logic of judge depend item finished in the dependent node
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on issue #10936:
URL: https://github.com/apache/dolphinscheduler/issues/10936#issuecomment-1183008307
Please describe your problem clearly, and AFAIK, we use endTime in dependent node to judge if the dependent node finished is our expected. cc @caishunfeng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Tandoy commented on issue #10936: [Bug] [task-plugin] There is an error in the logic of judge depend item finished in the dependent node
Posted by GitBox <gi...@apache.org>.
Tandoy commented on issue #10936:
URL: https://github.com/apache/dolphinscheduler/issues/10936#issuecomment-1183939292
> > > Please describe your problem clearly, and AFAIK, we use endTime in dependent node to judge if the dependent node finished is our expected. cc @caishunfeng
> >
> >
> > IMO If there are multiple run records in the workflow, it should not be through the start time to obtain the last and latest workflow instance. As I described in what happened. cc @caishunfeng
>
> OK, I understand, I agree with we need to use endTime rather than startTime.
If there are schedule run and manual run in a workflow during the interval, shouldn't we get the latest run status to judge, not the last? This is my doubt. I look forward to your answer. Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun commented on issue #10936: [Bug] [task-plugin] There is an error in the logic of judge depend item finished in the dependent node
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on issue #10936:
URL: https://github.com/apache/dolphinscheduler/issues/10936#issuecomment-1183915399
> > Please describe your problem clearly, and AFAIK, we use endTime in dependent node to judge if the dependent node finished is our expected. cc @caishunfeng
>
> IMO If there are multiple run records in the workflow, it should not be through the start time to obtain the last and latest workflow instance. As I described in what happened. cc @caishunfeng
OK, I understand, I agree with we need to use endTime rather than startTime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #10936: [Bug] [task-plugin] There is an error in the logic of judge depend item finished in the dependent node
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #10936:
URL: https://github.com/apache/dolphinscheduler/issues/10936#issuecomment-1214484293
This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #10936: [Bug] [task-plugin] There is an error in the logic of judge depend item finished in the dependent node
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #10936:
URL: https://github.com/apache/dolphinscheduler/issues/10936#issuecomment-1225020060
This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org