You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2018/12/01 02:39:09 UTC
Re: Review Request 69307: Changed master to hold subscribers in a
circular buffer.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69307/#review210990
-----------------------------------------------------------
src/master/master.cpp
Lines 12105-12108 (original), 12105-12108 (patched)
<https://reviews.apache.org/r/69307/#comment295826>
Almost forgot to mention this:
Because of the `http.closed()` future attached to each connection, when we remove old connections this log line will be triggered.
I don't think it's possible to trigger the `Master::exited(id::UUID)` function outside of the operator event stream functions. So it may be fine to remove this line in favor of logging when the limit is reached.
- Joseph Wu
On Nov. 26, 2018, 3:40 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69307/
> -----------------------------------------------------------
>
> (Updated Nov. 26, 2018, 3:40 p.m.)
>
>
> Review request for mesos, Benno Evers, Benjamin Mahler, Gastón Kleiman, and Greg Mann.
>
>
> Bugs: MESOS-9258
> https://issues.apache.org/jira/browse/MESOS-9258
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds a flag (--max_event_stream_subscribers) to the master which
> controls how many active subscribers on the Master's event stream will
> be allowed at any time. The default is 25 subscribers.
>
>
> Diffs
> -----
>
> docs/configuration/master.md 575476728079d884fe86b1a3a56614647d1b572e
> src/master/constants.hpp 76ad0c3b1494cb97888af5545acc998b8fb15bf6
> src/master/flags.hpp ed2d76af2831d1b9718724936fd3e4850e99b332
> src/master/flags.cpp 2677738d19caa7d600e591aeb4fb37f0c2318d45
> src/master/master.hpp e77babf22126838c63cd05e483875c9beb3ac5ff
> src/master/master.cpp 1e326ec42a7f79a0835529a4655e7ec272f1cf40
> src/tests/api_tests.cpp fdd9f871f75617fc26a28679e2a1e41f506c6133
>
>
> Diff: https://reviews.apache.org/r/69307/diff/1/
>
>
> Testing
> -------
>
> ```
> make check
>
> src/mesos-tests --gtest_filter="*MaxEventStreamSubscribers*" --gtest_repeat=-1 --gtest_break_on_failure
> ```
>
>
> Thanks,
>
> Joseph Wu
>
>