You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2015/09/15 00:57:14 UTC
Review Request 38380: Minor cleanups in the perf event isolator.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38380/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Repository: mesos
Description
-------
This removes the special casing of the empty set of cgroups case to simplify the sample loop, along with some other minor cleanups.
Diffs
-----
src/slave/containerizer/isolators/cgroups/perf_event.cpp 7dc8b7a99074b74ade019ef4df296780650a2e4e
Diff: https://reviews.apache.org/r/38380/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request 38380: Minor cleanups in the perf event isolator.
Posted by Ben Mahler <be...@gmail.com>.
> On Sept. 14, 2015, 11:48 p.m., Cong Wang wrote:
> > src/slave/containerizer/isolators/cgroups/perf_event.cpp, line 374
> > <https://reviews.apache.org/r/38380/diff/1/?file=1073168#file1073168line374>
> >
> > I don't think cgroup can be destroyed while perf running, kernel should return EBUSY, no?
I'll remove the 'while' addition here, thanks!
> On Sept. 14, 2015, 11:48 p.m., Cong Wang wrote:
> > src/slave/containerizer/isolators/cgroups/perf_event.cpp, line 436
> > <https://reviews.apache.org/r/38380/diff/1/?file=1073168#file1073168line436>
> >
> > Just nit: the original comment is useful for understanding the code, event after this change.
Good to know, I personally didn't find it insightful, but I'll add back something.
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38380/#review98962
-----------------------------------------------------------
On Sept. 14, 2015, 10:57 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38380/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2015, 10:57 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This removes the special casing of the empty set of cgroups case to simplify the sample loop, along with some other minor cleanups.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/cgroups/perf_event.cpp 7dc8b7a99074b74ade019ef4df296780650a2e4e
>
> Diff: https://reviews.apache.org/r/38380/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 38380: Minor cleanups in the perf event isolator.
Posted by Cong Wang <cw...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38380/#review98962
-----------------------------------------------------------
src/slave/containerizer/isolators/cgroups/perf_event.cpp (line 374)
<https://reviews.apache.org/r/38380/#comment155718>
I don't think cgroup can be destroyed while perf running, kernel should return EBUSY, no?
src/slave/containerizer/isolators/cgroups/perf_event.cpp (line 423)
<https://reviews.apache.org/r/38380/#comment155719>
Just nit: the original comment is useful for understanding the code, event after this change.
- Cong Wang
On Sept. 14, 2015, 10:57 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38380/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2015, 10:57 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This removes the special casing of the empty set of cgroups case to simplify the sample loop, along with some other minor cleanups.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/cgroups/perf_event.cpp 7dc8b7a99074b74ade019ef4df296780650a2e4e
>
> Diff: https://reviews.apache.org/r/38380/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 38380: Minor cleanups in the perf event isolator.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38380/#review98951
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Sept. 14, 2015, 10:57 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38380/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2015, 10:57 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This removes the special casing of the empty set of cgroups case to simplify the sample loop, along with some other minor cleanups.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/cgroups/perf_event.cpp 7dc8b7a99074b74ade019ef4df296780650a2e4e
>
> Diff: https://reviews.apache.org/r/38380/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>