You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2026/06/19 02:24:43 UTC

Re: [PR] fix: increase dataset edit modal size (#38215) [superset]

rusackas commented on PR #39257:
URL: https://github.com/apache/superset/pull/39257#issuecomment-4747897041

   Thanks @Vikash-Kumar-23, but this is still conflicting against `master` and needs a rebase before it can go anywhere. 
   
   Also still seeing the open bot notes: the `canEdit` prop on `TextAreaControl` isn't a real prop, and `.datasource-label-cell` is still applied on the metrics `verbose_name` column though its width rule was dropped. 
   
   Mind cleaning those up in the same pass, and then we'll review again?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org