You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/31 02:14:43 UTC

[GitHub] [arrow-rs] viirya opened a new issue, #1766: Remove

viirya opened a new issue, #1766:
URL: https://github.com/apache/arrow-rs/issues/1766

   **Is your feature request related to a problem or challenge? Please describe what you are trying to do.*
   
   This is one issue found by enabling `generate_decimal128_case` integration case at C++ repo (https://github.com/apache/arrow/pull/13219). 
   
   This crate validates precision of decimal by `validate_decimal_precision` in few places, e.g. `DecimalBuilder`'s `append_value`. However, in decimal golden file `0.14.1_decimal.gold.json`, there are some values failing this check. C++ doesn't perform similar check as I did a search, and I can confirm that test case can be passed if I remove `validate_decimal_precision` check in `append_value`.
   
   I'm wondering if we should remove the check to pass the test case? Or leaving `generate_decimal128_case` as skipped test case at the integration test?
   
   **Describe the solution you'd like**
   
   Remove `validate_decimal_precision` check in `DecimalBuilder`'s `append_value` to pass the integration test case `generate_decimal128_case`.
   
   **Describe alternatives you've considered**
   
   Keep `generate_decimal128_case` as skipped test case
   
   **Additional context**
   Add any other context or screenshots about the feature request here.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb closed issue #1766: Remove `validate_decimal_precision` check in `DecimalBuilder.append_value`

Posted by GitBox <gi...@apache.org>.
alamb closed issue #1766: Remove `validate_decimal_precision` check in `DecimalBuilder.append_value`
URL: https://github.com/apache/arrow-rs/issues/1766


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org