You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2021/09/23 07:52:54 UTC
[GitHub] [libcloud] mgorny opened a new pull request #1606: setup.py: Fix invalid python_requires
mgorny opened a new pull request #1606:
URL: https://github.com/apache/libcloud/pull/1606
Fix python_requires to use >=3.5 instead of >=3.5.*, as the latter
is invalid. It caused distlib to crash:
```
$ python -c "import distlib.database; list(distlib.database.DistributionPath(include_egg=True).get_distributions())"
Traceback (most recent call last):
File "<string>", line 1, in <module>
File "/usr/lib/python3.8/site-packages/distlib/database.py", line 213, in get_distributions
self._generate_cache()
File "/usr/lib/python3.8/site-packages/distlib/database.py", line 167, in _generate_cache
for dist in self._yield_distributions():
File "/usr/lib/python3.8/site-packages/distlib/database.py", line 157, in _yield_distributions
yield old_dist_class(r.path, self)
File "/usr/lib/python3.8/site-packages/distlib/database.py", line 879, in __init__
metadata = self._get_metadata(path)
File "/usr/lib/python3.8/site-packages/distlib/database.py", line 965, in _get_metadata
metadata.add_requirements(requires)
File "/usr/lib/python3.8/site-packages/distlib/metadata.py", line 1039, in add_requirements
self._legacy.add_requirements(requirements)
File "/usr/lib/python3.8/site-packages/distlib/metadata.py", line 575, in add_requirements
self['Requires-Dist'] += requirements
File "/usr/lib/python3.8/site-packages/distlib/metadata.py", line 276, in __setitem__
return self.set(name, value)
File "/usr/lib/python3.8/site-packages/distlib/metadata.py", line 453, in set
if not scheme.is_valid_matcher(v.split(';')[0]):
File "/usr/lib/python3.8/site-packages/distlib/version.py", line 703, in is_valid_matcher
self.matcher(s)
File "/usr/lib/python3.8/site-packages/distlib/version.py", line 115, in __init__
raise ValueError('\'.*\' not allowed for '
ValueError: '.*' not allowed for '>=' constraints
```
## Changes Title (replace this with a logical title for your changes)
### Description
Replace this with the PR description (mention the changes you have made, why
you have made them, provide some background and any references to the provider
documentation if needed, etc.).
For more information on contributing, please see [Contributing](http://libcloud.readthedocs.org/en/latest/development.html#contributing)
section of our documentation.
### Status
Replace this: describe the PR status. Examples:
- work in progress
- done, ready for review
### Checklist (tick everything that applies)
- [ ] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
- [ ] Documentation
- [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] asfgit merged pull request #1606: setup.py: Fix invalid python_requires
Posted by GitBox <gi...@apache.org>.
asfgit merged pull request #1606:
URL: https://github.com/apache/libcloud/pull/1606
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] Kami commented on pull request #1606: setup.py: Fix invalid python_requires
Posted by GitBox <gi...@apache.org>.
Kami commented on pull request #1606:
URL: https://github.com/apache/libcloud/pull/1606#issuecomment-940846099
Thanks for contributing the fix.
Do we know when this change was introduced? Do we need to do a bug fix release with this fix to avoid issues and errors on installation (and which Python versions does it affect?)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] Kami commented on pull request #1606: setup.py: Fix invalid python_requires
Posted by GitBox <gi...@apache.org>.
Kami commented on pull request #1606:
URL: https://github.com/apache/libcloud/pull/1606#issuecomment-949391008
@mgorny Thanks for the clarification.
I will try to merge some more of the open and finished PR and then work on a new release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] mgorny commented on pull request #1606: setup.py: Fix invalid python_requires
Posted by GitBox <gi...@apache.org>.
mgorny commented on pull request #1606:
URL: https://github.com/apache/libcloud/pull/1606#issuecomment-940966316
> Thanks for contributing the fix.
>
> Do we know when this change was introduced?
8375b29ee0f1b3147a1bf83c7c86260826e03751, so late 2019.
> Do we need to do a bug fix release with this fix to avoid issues and errors on installation (and which Python versions does it affect?)?
It's not that big deal — so far the only thing I've seen broken by that is `distlib`'s test suite itself. I don't think it justifies an urgent release by itself. However, given that the last release was in January, I suppose a new one would be in order soonish ;-).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org