You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/11/22 08:20:53 UTC
[GitHub] [cloudstack] harikrishna-patnala opened a new pull request #5703: UI: show button for dynamic Scaling for VM in case of KVM hypervisor
harikrishna-patnala opened a new pull request #5703:
URL: https://github.com/apache/cloudstack/pull/5703
### Description
Enabled UI button for Dynamic scaling of VM which are on KVM. API support is already here https://github.com/apache/cloudstack/pull/4878
There are few constraints with KVM support for dynamic scaling like it has to be custom compute offering and need to set maxmemory, but showing it in UI adds value. It fails with an appropriate error when fixed compute offering is used, so it is worth adding to UI. We can also disable the button in such cases but it may confuse users why it is disabled.
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] slavkap commented on pull request #5703: UI: show button for dynamic Scaling for VM in case of KVM hypervisor
Posted by GitBox <gi...@apache.org>.
slavkap commented on pull request #5703:
URL: https://github.com/apache/cloudstack/pull/5703#issuecomment-975268113
LGTM, I did a few manual tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5703: UI: show button for dynamic Scaling for VM in case of KVM hypervisor
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5703:
URL: https://github.com/apache/cloudstack/pull/5703#issuecomment-975331459
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5703: UI: show button for dynamic Scaling for VM in case of KVM hypervisor
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5703:
URL: https://github.com/apache/cloudstack/pull/5703#issuecomment-975332386
@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5703: UI: show button for dynamic Scaling for VM in case of KVM hypervisor
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5703:
URL: https://github.com/apache/cloudstack/pull/5703#issuecomment-975338480
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5703 (SL-JID-847)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #5703: UI: show button for dynamic Scaling for VM in case of KVM hypervisor
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #5703:
URL: https://github.com/apache/cloudstack/pull/5703
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org