[GitHub] [cloudstack] stephankruggg commented on a diff in pull request #6996: [VMware] Remove unnecessary logs on VM deployments

[GitBox <gi...@apache.org>]

stephankruggg commented on code in PR #6996:
URL: https://github.com/apache/cloudstack/pull/6996#discussion_r1049614963


##########
utils/src/main/java/com/cloud/utils/nicira/nvp/plugin/NiciraNvpApiVersion.java:
##########
@@ -40,8 +40,10 @@ public static synchronized boolean isApiVersionLowerThan(String apiVersion){
         return (compare < 0);
     }
 
-    public static synchronized void logNiciraApiVersion(){
-        s_logger.info("NSX API VERSION: " + ((niciraApiVersion != null) ? niciraApiVersion : " NOT PRESENT"));
+    public static synchronized void logNiciraApiVersion() {
+        if (niciraApiVersion != null) {
+            s_logger.info("NSX API VERSION: " + niciraApiVersion);

Review Comment:
   ```suggestion
               s_logger.info(String.format("NSX API VERSION: [%s]", niciraApiVersion));
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org