[GitHub] spark pull request #12105: [SPARK-14321][SQL] Reduce date format cost and st...

[rajeshbalamohan <gi...@git.apache.org>]

Github user rajeshbalamohan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12105#discussion_r65885590
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ---
    @@ -391,21 +393,24 @@ abstract class UnixTime extends BinaryExpression with ExpectsInputTypes {
           case StringType if right.foldable =>
             val sdf = classOf[SimpleDateFormat].getName
             val fString = if (constFormat == null) null else constFormat.toString
    -        val formatter = ctx.freshName("formatter")
             if (fString == null) {
               s"""
                 boolean ${ev.isNull} = true;
                 ${ctx.javaType(dataType)} ${ev.value} = ${ctx.defaultValue(dataType)};
               """
             } else {
    +          val formatter = ctx.freshName("formatter")
    +          ctx.addMutableState(sdf, formatter, s"""$formatter = null;""")
    --- End diff --
    
    yes. Creating the formatter here did not create any issues.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org