You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@ambari.apache.org by Myroslav Papirkovskyy <mp...@hortonworks.com> on 2017/11/20 16:16:20 UTC

Review Request 63957: Stack advisor should disallow lzo enable without accepting license agreement.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63957/
-----------------------------------------------------------

Review request for Ambari, Andrew Onischuk and Sid Wagle.


Bugs: AMBARI-22484
    https://issues.apache.org/jira/browse/AMBARI-22484


Repository: ambari


Description
-------

If the user adds com.hadoop.compression.lzo.LzoCodec to core-site property io.compression.codec.lzo.class and the ambari.properties does not have the allow GPL software install flag, throw validation error


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorRequest.java 64180e5039bdb74d3aaf25e140565c82a95a26c1 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java 5440462b86cdcfafb1e9ab239dacfddee0b31b93 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java b2a68d66d777f107fdc4f5576a691e8d25ec2c92 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProvider.java dd32c6badb18c1a8c02b7093813cd92ccd2fc74c 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py c36a41f49b224a904368c7474f0f769348e65ae6 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ValidationResourceProviderTest.java cdbf2d782f86b2a30f54619c4e2a9165a020275c 
  ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 9e0070458987ee490f3918fead5ef11d201c8612 


Diff: https://reviews.apache.org/r/63957/diff/1/


Testing
-------

mvn clean test


Thanks,

Myroslav Papirkovskyy