[jira] [Commented] (AMBARI-4034) Create the RequestSchedule resource provider

["Sumit Mohanty (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMBARI-4034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13855896#comment-13855896 ] 

Sumit Mohanty commented on AMBARI-4034:
---------------------------------------

Looks good. Few comments:

Can we rename classes with *RequestExecution* in name to *RequestSchedule*?

* ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
** If we delete a RequestSchedule resource, what happens to the underlying Request that got spawned because of the one being deleted? For now, we could not delete RS instances as we also do not allow delete of Requests either.
** Can a RS be disabled? So that no new request execution instance get fired.

* ambari-server/src/test/java/org/apache/ambari/server/orm/InMemoryDefaultTestModule.java
** No change in this file.

* We need some unit test for the RequestSchedule API calls, and the changes to the JSON body parser

> Create the RequestSchedule resource provider
> --------------------------------------------
>
>                 Key: AMBARI-4034
>                 URL: https://issues.apache.org/jira/browse/AMBARI-4034
>             Project: Ambari
>          Issue Type: Task
>          Components: controller
>    Affects Versions: 1.5.0
>            Reporter: Siddharth Wagle
>            Assignee: Siddharth Wagle
>             Fix For: 1.5.0
>
>         Attachments: AMBARI-4034.patch
>
>
> -    Add a resource provider for the new resource
> -    Support predicate filtering on the sub-resources
> -    Add unit tests for all supported CRUD operations



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)