You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/05/29 23:33:27 UTC
[GitHub] [hudi] nsivabalan opened a new pull request #1688: [HUDI-980] Fixing dir path for metastore_db and derby.logs generated in hive tests
nsivabalan opened a new pull request #1688:
URL: https://github.com/apache/hudi/pull/1688
After running TestHiveSyncTool, some remnants are found in source dir(hudi-hive-sync). Eg, metastore_db and derby.logs. This patch fixes the same. This indirectly causes compilation of hudi to fail. Once you run unit tests, if you try to compile, it may complain about license headers in these generated files.
Source: https://stackoverflow.com/questions/38377188/how-to-get-rid-of-derby-log-metastore-db-from-spark-shell
Verification:
- Verified that these are created in the temp dir created as part of tests and no remnants are found in hudi-hive-sync.
- Ran entire TestHiveSyncTool. All passed.
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan merged pull request #1688: [HUDI-980] Fixing dir path for metastore_db and derby.logs generated in hive tests
Posted by GitBox <gi...@apache.org>.
nsivabalan merged pull request #1688:
URL: https://github.com/apache/hudi/pull/1688
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #1688: [HUDI-980] Fixing dir path for metastore_db and derby.logs generated in hive tests
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #1688:
URL: https://github.com/apache/hudi/pull/1688#issuecomment-636240008
sure @bvaradar . thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codecov-commenter commented on pull request #1688: [HUDI-980] Fixing dir path for metastore_db and derby.logs generated in hive tests
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1688:
URL: https://github.com/apache/hudi/pull/1688#issuecomment-636247782
# [Codecov](https://codecov.io/gh/apache/hudi/pull/1688?src=pr&el=h1) Report
> Merging [#1688](https://codecov.io/gh/apache/hudi/pull/1688?src=pr&el=desc) into [master](https://codecov.io/gh/apache/hudi/commit/5a0d3f1cf963e0061364d915ac86a465dd079bac&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/hudi/pull/1688?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1688 +/- ##
=========================================
Coverage 18.19% 18.19%
Complexity 856 856
=========================================
Files 348 348
Lines 15344 15344
Branches 1523 1523
=========================================
Hits 2792 2792
Misses 12195 12195
Partials 357 357
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/hudi/pull/1688?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/hudi/pull/1688?src=pr&el=footer). Last update [5a0d3f1...ae8f004](https://codecov.io/gh/apache/hudi/pull/1688?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org