[GitHub] [calcite] rubenada commented on a change in pull request #1575: [CALCITE-3498] Unnest operation's ordinality should be deterministic

[GitBox <gi...@apache.org>]

rubenada commented on a change in pull request #1575: [CALCITE-3498] Unnest operation's ordinality should be deterministic
URL: https://github.com/apache/calcite/pull/1575#discussion_r345738737
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java
 ##########
 @@ -2747,6 +2747,14 @@ public static Object structAccess(Object structObject, int index, String fieldNa
       list = Arrays.asList(flatElements);
     }
 
+    @Override public boolean moveNext() {
 
 Review comment:
   Well spotted!
   I have not tested it, but I think we should probably override the reset method too, with something like:
   ```
       @Override public void reset() {
         super.reset();
         if (withOrdinality) {
           ordinality = 0;
         }
       }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services