You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2016/04/26 03:08:14 UTC
Review Request 46669: Added deprecation support to Flag name.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46669/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271
Repository: mesos
Description
-------
Added deprecation support to Flag name.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp c3cbcdb781e1c282d381de1ad2bf4f386ee1db21
Diff: https://reviews.apache.org/r/46669/diff/
Testing
-------
Tested manually by running ./bin/mesos-master.sh --authenticate
The one caveat is that the deprecation warning might be printed before logging the library is initialized (e.g., master/main.cpp calls flags.load() before logging::initialize(flags)).
Thanks,
Vinod Kone
Re: Review Request 46669: Added deprecation support to Flag name.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46669/
-----------------------------------------------------------
(Updated April 30, 2016, 3:44 a.m.)
Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.
Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271
Repository: mesos
Description
-------
Added deprecation support to Flag name.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/README.md 45dd8f39de9fa34cc11befbe842319079685db02
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp c3cbcdb781e1c282d381de1ad2bf4f386ee1db21
3rdparty/libprocess/3rdparty/stout/include/stout/subcommand.hpp 4d37c4afdcf4c3d6d511dd8a27916332b086afa7
3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 66e16abe914e2a1ee7599bab857ff478b7ec20dc
Diff: https://reviews.apache.org/r/46669/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 46669: Added deprecation support to Flag name.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46669/
-----------------------------------------------------------
(Updated April 30, 2016, 2:01 a.m.)
Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.
Changes
-------
mpark's comments.
Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271
Repository: mesos
Description
-------
Added deprecation support to Flag name.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/README.md 45dd8f39de9fa34cc11befbe842319079685db02
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp c3cbcdb781e1c282d381de1ad2bf4f386ee1db21
3rdparty/libprocess/3rdparty/stout/include/stout/subcommand.hpp 4d37c4afdcf4c3d6d511dd8a27916332b086afa7
3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 66e16abe914e2a1ee7599bab857ff478b7ec20dc
Diff: https://reviews.apache.org/r/46669/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 46669: Added deprecation support to Flag name.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46669/
-----------------------------------------------------------
(Updated April 29, 2016, 7:08 p.m.)
Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.
Changes
-------
updated testing section.
Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271
Repository: mesos
Description
-------
Added deprecation support to Flag name.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/README.md 45dd8f39de9fa34cc11befbe842319079685db02
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp c3cbcdb781e1c282d381de1ad2bf4f386ee1db21
3rdparty/libprocess/3rdparty/stout/include/stout/subcommand.hpp 4d37c4afdcf4c3d6d511dd8a27916332b086afa7
3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 66e16abe914e2a1ee7599bab857ff478b7ec20dc
Diff: https://reviews.apache.org/r/46669/diff/
Testing (updated)
-------
make check
Thanks,
Vinod Kone
Re: Review Request 46669: Added deprecation support to Flag name.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46669/
-----------------------------------------------------------
(Updated April 29, 2016, 3:28 a.m.)
Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.
Changes
-------
Ben's comments.
Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271
Repository: mesos
Description
-------
Added deprecation support to Flag name.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp c3cbcdb781e1c282d381de1ad2bf4f386ee1db21
3rdparty/libprocess/3rdparty/stout/include/stout/subcommand.hpp 4d37c4afdcf4c3d6d511dd8a27916332b086afa7
3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 66e16abe914e2a1ee7599bab857ff478b7ec20dc
Diff: https://reviews.apache.org/r/46669/diff/
Testing
-------
Tested manually by running ./bin/mesos-master.sh --authenticate
The one caveat is that the deprecation warning might be printed before logging the library is initialized (e.g., master/main.cpp calls flags.load() before logging::initialize(flags)).
Thanks,
Vinod Kone
Re: Review Request 46669: Added deprecation support to Flag name.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46669/#review130675
-----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp (line 91)
<https://reviews.apache.org/r/46669/#comment194515>
s/effectiveName/effective_name/
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp (lines 951 - 955)
<https://reviews.apache.org/r/46669/#comment194514>
return warning as a string/Warning instead of directly logging here.
- Vinod Kone
On April 26, 2016, 1:08 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46669/
> -----------------------------------------------------------
>
> (Updated April 26, 2016, 1:08 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-5271
> https://issues.apache.org/jira/browse/MESOS-5271
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added deprecation support to Flag name.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp c3cbcdb781e1c282d381de1ad2bf4f386ee1db21
>
> Diff: https://reviews.apache.org/r/46669/diff/
>
>
> Testing
> -------
>
> Tested manually by running ./bin/mesos-master.sh --authenticate
>
> The one caveat is that the deprecation warning might be printed before logging the library is initialized (e.g., master/main.cpp calls flags.load() before logging::initialize(flags)).
>
>
> Thanks,
>
> Vinod Kone
>
>