You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2022/10/09 08:33:40 UTC

[GitHub] [shenyu] zhc00 opened a new issue, #4055: [Task] refinement ShenYu Admin

zhc00 opened a new issue, #4055:
URL: https://github.com/apache/shenyu/issues/4055

   ### Description
   
   I propose to refine the API and API document of ShenYu Admin. the key is that let it follow the OpenAPI 3.0 specification completely. 
   
   
   ### Task List
   
   1. API document, there are many meaningless descriptions.
   1. unify the message of Response to `success` or `query success` when querying successfully. I see we unified most queries to `query success.
   1. Missing mode detail in Response. For example, `ShenyuAdminResult` missed the details of the data.
   1. refactor the structure of `/selector/list/search` and `/rule/list/search`.  Let it be like `/selector` or `/rule`
   2. fix `/selector` and `/rule` missing `required` symbol in `pluginId` and `selectorId`.
   1. return **`200 ok`** when the resource is not found in `GET /selector/{id}` or `GET /rule/{id}`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shenyu] homihq commented on issue #4055: [Task] refinement ShenYu Admin

Posted by GitBox <gi...@apache.org>.
homihq commented on issue #4055:
URL: https://github.com/apache/shenyu/issues/4055#issuecomment-1286414616

   I can volunteer on this one. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shenyu] zhc00 commented on issue #4055: [Task] refinement ShenYu Admin

Posted by GitBox <gi...@apache.org>.
zhc00 commented on issue #4055:
URL: https://github.com/apache/shenyu/issues/4055#issuecomment-1272489538

   This proposal is important. It will make the UI broken.
   So welcome to discuss this topic with me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shenyu] mahaitao617 commented on issue #4055: [Task] refinement ShenYu Admin

Posted by GitBox <gi...@apache.org>.
mahaitao617 commented on issue #4055:
URL: https://github.com/apache/shenyu/issues/4055#issuecomment-1310395469

   please assign 4 、5 to me,ths


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shenyu] yu199195 closed issue #4055: [Task] refinement ShenYu Admin

Posted by "yu199195 (via GitHub)" <gi...@apache.org>.
yu199195 closed issue #4055: [Task] refinement ShenYu Admin
URL: https://github.com/apache/shenyu/issues/4055


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org